Commit Graph
100 Commits
Author SHA1 Message Date
pj 6234bf5ba0 fix(ios): a failed devicectl uninstall must fail the reinstall
same hole as the simulator path: devicectl install over an app keeps its data, and the discarded uninstall error hid it. Uninstalling a bundle id that is not installed exits 0 with 'App uninstalled.' on a paired iPhone, so a failure here is always real.
2026-08-16 00:02:36 +05:30
pj abc5e7db3e fix(ios): a failed simctl uninstall must fail the reinstall
simctl install over an installed app carries its data container across, so discarding the uninstall error reported a clear-state that never happened. Uninstalling an app that is not installed exits 0 on a booted simulator, so every failure here is a real one.
2026-08-16 00:01:40 +05:30
pj 1ec6eb3847 fix(android): a refused uninstall must not pass for clear-state
adb uninstall answers Failure [DELETE_FAILED_INTERNAL_ERROR] both when the package was never installed and when it refuses to remove one, so the failure text cannot say which happened and the old code installed over the top either way, keeping the data clear-state was asked to drop. Ask pm path instead, and fall back to pm clear when the app is still there.
2026-08-16 00:00:36 +05:30
pj 17f0a020fa Merge branch 'spec-authoring-skills' into trial-merge 2026-08-15 23:04:37 +05:30
pj 112d347432 refactor(folio): name the balance property for the bound it asserts
it stopped being an equality and became |delta| <= typed, so the old name
demanded more than the property does. renamed with the ci gate's
GATED_PROPERTIES in the same commit so the gate never sees a name it does
not know.
2026-08-15 23:04:15 +05:30
pj 6a7764eac7 Merge branch 'folio-spec-attribution' into trial-merge 2026-08-15 23:03:50 +05:30
pj 8ad68b278f docs(folio): record why a banked card reading can be trusted as current
The freshness rule rests on the app popping one entry back to the ledger,
not on anything the frame carries, so the assumption and the measurements
behind it belong next to it.
2026-08-15 23:02:42 +05:30
pj 4027aa1e44 test(folio): pin that a commit stays in the window until Home reads it
The interaction that keeps a stale Home card list from ever banking counts
the budget has already forgotten: a submit lands on the ledger, so the
reading that resets the window is a whole action later and the submit is
still in it. Characterization, not a regression: no code changed and it
cannot go red first.
2026-08-15 23:02:37 +05:30
pj b554a9ecee docs(manual): correct the flags the cli reference gets wrong
--launcher-activity does not exist in cmd/sanderling/main.go. --device,
--android-app-path and --arm do and were undocumented. runs.md still listed
--max-steps and --exit-on-violation as unshipped, and described --clear-data
as opt-in when the default is already true, contradicting itself ten lines on.
2026-08-15 23:00:16 +05:30
pj b241a2cc64 Merge branch 'trial-merge' into spec-authoring-skills 2026-08-15 22:59:47 +05:30
pj 1adbb35305 Merge branch 'skills-setup-and-triage' into spec-authoring-skills 2026-08-15 22:59:47 +05:30
pj fb1b482ab1 docs(skills): point the setup skill at its siblings 2026-08-15 22:58:41 +05:30
pj ffc857f58f Merge branch 'spec-authoring-skills' into skills-setup-and-triage 2026-08-15 22:58:07 +05:30
pj a51c8cb742 docs(skills): add a run triage skill 2026-08-15 22:57:42 +05:30
pj 221c9a91b5 Merge branch 'spec-authoring-skill-writing' into spec-authoring-skills 2026-08-15 22:57:18 +05:30
pj 64b9087be2 Merge branch 'sanderling-property-patterns-skill' into spec-authoring-skills 2026-08-15 22:57:18 +05:30
pj ae0694cd8b docs(skills): add a setup skill for adopting sanderling 2026-08-15 22:56:31 +05:30
pj d79fb3f2d6 docs(skills): name the selector keys that still substring match 2026-08-15 22:56:28 +05:30
pj 7068b03ffc docs(skills): ground the property patterns catalogue in the merged specs 2026-08-15 22:55:56 +05:30
pj 2394c29d10 docs(skills): add a spec authoring skill
covers hooks, extractors, selectors, properties, actions and the order to write them in, with a complete sample spec that typechecks against the real export surface.
2026-08-15 22:55:15 +05:30
pj 21a020de74 docs(folio): say what property 2 demands now that it is a bound 2026-08-15 22:55:13 +05:30
pj 6e8e6d51fe fix(folio): bound the total-balance move instead of demanding it exactly
The write finishes before AddTransactionViewModel navigates, but nothing
establishes that Home's total has re-rendered before the frame is read, and
an equality convicts a healthy app for a total one frame behind. A delta of
zero is exactly the shape nine of the eleven measured android false
convictions had. 2x still exceeds x, so all four recorded convictions
survive, checked against the traces.

The trade is real: a balance that moves by LESS than the amount typed is no
longer judged anywhere in this spec.
2026-08-15 22:55:09 +05:30
pj 48e901bd9b Merge branch 'android-home-diagnostic' into trial-merge 2026-08-15 22:51:48 +05:30
pj 404ce4bcbb Merge branch 'spec-authoring-skills' into sanderling-property-patterns-skill 2026-08-15 22:50:56 +05:30
pj ac4846bf55 Merge branch 'trial-merge' into spec-authoring-skills 2026-08-15 22:50:21 +05:30
pj 1ca812beed docs(skills): add a property patterns catalogue skill 2026-08-15 22:48:27 +05:30
pj e61b39f2e3 test(testrun): cover the sidecar shutdown path after an early exit 2026-08-15 22:46:47 +05:30
pj 708a8a2929 fix(testrun): report a sidecar that dies at startup as the exit it was 2026-08-15 22:42:26 +05:30
pj 049b8d513e docs(skills): add a spec review skill and the skills index 2026-08-15 22:39:47 +05:30
pj f819dad7b6 fix(testrun): preflight resolves adb through the sdk, not just PATH 2026-08-15 22:39:38 +05:30
pj 3af6791029 docs(cli): the android doctor checks are not path-only 2026-08-15 22:38:34 +05:30
pj 22115a6c25 fix(doctor): resolve adb and emulator the way a run does 2026-08-15 22:38:23 +05:30
pj a5f86334af fix(android): say what the sdk lookup checked, not just to set ANDROID_HOME 2026-08-15 22:36:50 +05:30
pj f9b13b1781 Merge branch 'sidecar-adb-and-ime' into trial-merge 2026-08-15 22:31:31 +05:30
pj 19707df04d docs(ci): the android step number describes a local emulator, not ci
the leg disables animations and the number was measured with them on. the
first real dispatch carries 4 transitional steps over 200, so the cross-fade
wait does still fire in ci, just far less often.
2026-08-15 22:25:54 +05:30
pj e67fffcab7 test(sidecar): use the tree the device really returns 2026-08-15 22:19:49 +05:30
pj 3df8a3b3ba fix(sidecar): find the erased field by class, past the keyboard's own focus
The check that decides whether the select-all worked looked for an
"editable" attribute maestro's tree does not carry, so it answered
"cannot tell" every time and every erase paid the per-character
fallback. Worse, an open keyboard puts a second focused node in the
tree, one of the IME's own keys, carrying no text: taking the first
focused node would read a field still holding 4096 characters as empty,
which is the one answer that stops the erase early.

Match the text field by class instead. Measured against the real
backend, 4096 characters now clear in 385ms on API 34, 409ms on API 35
and 870ms on API 36, verified empty, where the fallback took ~4s.
2026-08-15 22:19:49 +05:30
pj b3a565e9e9 test(sidecar): pin the constant-cost erase and its residue check 2026-08-15 22:02:52 +05:30
pj 7fa2d71e99 fix(sidecar): erase a field by selecting it, not one delete per character
maestro's eraseText sends one delete per character through its
instrumentation, measured 29.6 ms/char on the API 34 emulator. The
4096-character string the corpus types cost ~121s to clear, a fifth of a
20 minute run spent on one step, and it recurred every time that field
was typed into again.

Select the content and delete the selection instead: two key events at
any length, measured 0.15s to 1.16s for 4096 characters across API 34,
35 and 36. The result is read back off the tree, and a field that is not
empty, or that the tree cannot report on, is finished off per character
in batches rather than assumed clear.

Fixes #80
2026-08-15 22:02:43 +05:30
pj b415323b08 Merge branch 'relaunch-signal-and-badge-reach' into trial-merge 2026-08-15 21:52:19 +05:30
pj cc2e0ecc35 docs(runner): describe both modes of the composing test driver 2026-08-15 21:46:30 +05:30
pj 7d4e85f407 refactor(runner): drop the empty branch from the hold path 2026-08-15 21:44:21 +05:30
pj dba9da8575 Merge branch 'ios-clear-before-session' into trial-merge 2026-08-15 21:43:31 +05:30
pj 5aee168098 fix(runner): hold the action back on a step nothing verified 2026-08-15 21:42:48 +05:30
pj 9f8afab9c0 test(runner): a skipped step must not swallow the action before it 2026-08-15 21:42:48 +05:30
pj 6cf67e709c Merge branch 'sidecar-adb-and-ime' into trial-merge 2026-08-15 21:37:00 +05:30
pj fef80e00ff fix(testrun): thread clear-data into the ios drivers 2026-08-15 21:31:53 +05:30
pj 67da9313dd fix(ios): the device path clears before its runner session too 2026-08-15 21:31:53 +05:30
pj aed65976e3 fix(ios): clear app state before the automation session attaches
New performs the clear-state reset, so the uninstall and reinstall no
longer land underneath a live XCTest session that is already bound to
the app. Launch refuses a clear-state request the driver was not built
for rather than reinstalling under its own session.
2026-08-15 21:31:48 +05:30
pj 985c6befdd test(runner): cover the reread's cost to the existing snapshot rules 2026-08-15 21:30:21 +05:30
pj 81b737188f feat(runner): skip a step whose tree changed between two reads 2026-08-15 21:30:21 +05:30
pj 2762dc3011 test(runner): answer Snapshot and Hierarchy off one tree in the fakes 2026-08-15 21:30:15 +05:30
pj bd72b0c2f7 Merge branch 'folio-spec-attribution' into trial-merge 2026-08-15 21:27:48 +05:30
pj 5b218edb92 Merge branch 'companion-honest-launch' into trial-merge 2026-08-15 21:27:48 +05:30
pj 79dbc471b8 Merge branch 'spec-parity-holes' into trial-merge 2026-08-15 21:27:47 +05:30
pj 40bd5322b7 Merge branch 'folio-amount-bounds' into trial-merge 2026-08-15 21:27:47 +05:30
pj ec1fdc85ad test(sidecar): pin the degraded typing guard both ways 2026-08-15 21:26:51 +05:30
pj 8d7ef4d681 fix(sidecar): a foreground read that fails degrades the typing guard
An unreadable dumpsys passed a null owner to typeChunks, which switches
the mid-type focus guard off outright and lets the rest of the string
spray into whatever holds the foreground. Fall back to the launched
bundle instead: the guard stays armed, typing still happens, and the
degradation is said out loud rather than assumed away.
2026-08-15 21:26:51 +05:30
pj ae3c9fe091 feat(folio): read the amount field into every submit window
Each of the three windows asks whether the tap could have committed, off the
field as the landing frame shows it.
2026-08-15 21:24:57 +05:30
pj 6b276253e8 fix(folio): stop spending the submit budget on taps the app refused
The window is an upper bound on the transactions an interval could hold, and
a bound inflated by taps that commit nothing is a bound the app can never
exceed: #78 read a rise of 15 transactions against 37 submits. TxnSubmit is
clickable(enabled = amount.isNotBlank()) and parseCents refuses anything its
regex misses, so a tap whose landing frame shows a refused amount cannot have
committed. Over four recorded android runs that is 19, 11, 25 and 25 of 35,
26, 42 and 42 submit taps.

A relaunch is excepted: a fresh process draws an empty field whatever was
submitted.
2026-08-15 21:24:53 +05:30
pj 07e8abb9ef test(sidecar): unknown animation state must not read as idle 2026-08-15 21:23:45 +05:30
pj 9ff82b1565 fix(sidecar): an unreadable animation count is not idle
Defaulting the count to zero made a dumpsys that said nothing mean
nothing is animating, so a degraded link broke out of the settle early
and handed the runner a frame caught mid-animation. Unknown now waits,
inside the deadline waitForIdle already holds.
2026-08-15 21:23:45 +05:30
pj 34b8be2d8c test(sidecar): pin the bound on a wedged adb read 2026-08-15 21:17:09 +05:30
pj 23a2454459 fix(sidecar): bound the diagnostic adb reads
adbOutput and readLogcat read to EOF and then waited with no timeout, so
a wedged adb held the step for as long as it liked; one stall over a
remote adb server measured ~100s. The bound has to sit on the read, not
on waitFor: a wedged adb never reaches EOF, so a bounded waitFor after
the read is a line that never runs.
2026-08-15 21:17:06 +05:30
pj ff7dde4be8 test(folio): pin that two accounts can render the same card text
The proof behind the comment: "Travel1" holding 25 transactions and
"Travel12" holding 5 merge to the same string, so no identity key read off
a web card can tell them apart.
2026-08-15 21:12:36 +05:30
pj 95e0ab8afa docs(folio): say why the merged card key cannot be made injective
Folio rejects a duplicate account name, so the twin the drop rule guards
against is two names the web key cannot tell apart, not two accounts
sharing a name. State what closing the rest would cost and what the tree
would have to carry to close it properly.
2026-08-15 21:11:47 +05:30
pj 9770537aa6 fix(folio): decline the two demanding properties across a relaunch
The runner now keeps lastAction and marks it relaunched: true where it used
to report nothing at all, so the two properties that demand an effect judge
a step whose process may have died before the write landed.
submitChangesBalanceByTypedAmount and createdAccountHasNonZeroBalance both
decline there. The counting bound does not: a relaunch cannot manufacture a
transaction, and the submit is counted, so declining would throw away the
detection the runner fix restored.
2026-08-15 21:11:30 +05:30
pj 64f99babd5 docs(sidecar): put the measured read cost in the dismissal bound 2026-08-15 21:08:03 +05:30
pj f65bc1631c ci: switch to jdk 21 only for the folio step 2026-08-15 21:08:03 +05:30
pj cc32640d03 ci: run folio's unit tests on every pr 2026-08-15 21:08:03 +05:30
pj ca409ca6b8 chore(folio): a just recipe for the unit tests 2026-08-15 21:08:03 +05:30
pj fbc5102b25 chore(make): a target that runs folio's unit tests 2026-08-15 21:08:03 +05:30
pj 1e350f7fd3 test(sidecar): pin the tree-guarded keyboard dismissal 2026-08-15 21:08:03 +05:30
pj b4cd9d5cd1 fix(sidecar): close a keyboard standing in the snapshot
A tap on a text field raises the keyboard and nothing closed it, so the
tree the picker chooses from was missing every app node underneath it,
the submit control included. Close it before the read rather than after
the tap: the picker only ever sees snapshots, and the keyboard is still
on its way up when the tap returns.

Fixes #78
2026-08-15 21:08:03 +05:30
pj a71cbfc685 test(sidecar): pin the adb server endpoint parsing 2026-08-15 21:08:03 +05:30
pj 83e9d5fd95 fix(sidecar): reach the adb server the environment names
buildDadb hardcoded localhost:5037, so a serial-addressed device always
resolved through this machine's adb server and ADB_SERVER_SOCKET was
ignored. Read the endpoint the way the adb CLI does instead.

Fixes #79
2026-08-15 21:08:03 +05:30
pj 0e096c00b3 feat(folio): close the submit window on the account's own screens
submitCommitsOneTransactionPerAction now states its rule over two windows:
the Home counts it already compared, and the account balance the ledger and
the add-transaction screen redraw on nearly every frame of the transaction
flow. Same rule, and the second window is usually one action wide.
2026-08-15 21:04:39 +05:30
pj bc73975604 docs(replay-ui): name the viewport the tab overflow was measured at 2026-08-15 21:03:55 +05:30
pj e686362fb6 docs(runner): point the guard comment at the renamed test 2026-08-15 21:03:43 +05:30
pj 94a1d59d60 test(runner): an overlay dismissal must not convict the counting property 2026-08-15 21:03:23 +05:30
pj 2d789d7d17 feat(folio): judge a submit against the account's own balance
The counting invariant can only close its window on Home, and the iOS run
in #78 went 117 steps between two Home readings: 37 submits against a rise
of 15 transactions is no evidence about the double tap sitting inside it.
The ledger and the add-transaction screen both show the account's own
balance, and an accepted submit pops back to the ledger, so a window
bounded by those readings holds one action.

The bound is an upper one: a balance that has not moved is a commit still
in flight, a rejected submit or a tap that never landed, and none of those
is a violation. Moving by more than the one submit in the window typed is.
2026-08-15 21:03:07 +05:30
pj 578ead6554 test(replay-ui): drive the fuzzer onto a violating step with a panel 2026-08-15 21:01:10 +05:30
pj 5be530bf17 fix(replay-ui): wrap the tab strip so its last tabs stay clickable 2026-08-15 20:57:55 +05:30
pj 047c53a2e7 test(browser): the cross-host fixture uses the object selector form 2026-08-15 20:52:43 +05:30
pj 4324573d97 test(verifier): both ax.find selector forms resolve the same element 2026-08-15 20:51:43 +05:30
pj ad63c5eb74 fix(hierarchy): object selectors resolve by the same rule as string ones 2026-08-15 20:50:55 +05:30
pj 4ac969bb3f fix(folio): attribute a created account by its whole key, not a suffix
createdAccountHasNonZeroBalance matched the created card with endsWith, so
an older account whose name ends with the typed one ("Emergency Fund" for a
typed "Fund") was judged instead whenever the new card was clipped out of
the reading. Build both keys the card can carry, the plain name and web's
initials + name, and compare them whole.
2026-08-15 20:49:38 +05:30
pj a7e94c85df test(ios): a refusal the runner names costs no session restart
The session restart is for a launch that never answers. A launch that
reports the app's state has already said what a fresh session would.
2026-08-15 20:49:35 +05:30
pj 73736ab26f fix(ios): the runner must not answer ok for a launch that failed
XCTest records a refused launch as a test issue that never throws, so the
companion returned ok for an app that never started. Check the state the
app actually reached and report the refusal instead.
2026-08-15 20:49:31 +05:30
pj 4caafafb1d Merge branch 'ci-hygiene-and-fmt' into trial-merge 2026-08-15 20:49:20 +05:30
pj b425cd0267 Merge branch 'android-ime-verify' into trial-merge 2026-08-15 20:49:20 +05:30
pj c50bf56cf3 style(sidecar): bring the last three lines under the line limit 2026-08-15 20:48:39 +05:30
pj 7623ca7a21 fix(folio): uninstall before installing in just ios
folio's signed-in session lives in the data container, which an install
over the top keeps, so a local run started right after just ios opened on
the previous run's Home screen and diverged at step 1. On CI's fresh
simulator the uninstall is a no-op, so the ios leg is unchanged.
2026-08-15 20:43:28 +05:30
pj 56d6aa53f1 test: pin that a nested undefined does not survive the wire 2026-08-15 20:42:36 +05:30
pj ca969f495a fix(runner): keep the action the app was relaunched after 2026-08-15 20:42:20 +05:30
pj 99160b4c12 test(verifier): pin the relaunch field on both hosts 2026-08-15 20:42:20 +05:30
pj 365418f73e feat(verifier): report a relaunch on state.lastAction 2026-08-15 20:42:20 +05:30
pj 3865c6515d ci: move every action off the node20 runtime
checkout v4->v7, setup-go v5->v7, setup-node v4->v7, setup-java v4->v5,
upload-artifact v4->v7, cache v4->v6, upload-pages-artifact v3->v5,
deploy-pages v4->v5, setup-chrome v1->v2, setup-android v3->v4,
goreleaser-action v6->v7. setup-bun and android-emulator-runner are
already node24; buf-setup-action stays on its deliberate SHA pin.

setup-chrome v2 resolves stable from Chrome for Testing rather than the
official installer, so the ci.yml comment about the action's default no
longer held.
2026-08-15 20:41:39 +05:30
pj 0cef5bd1d3 test(spec): name the shadow match in the grammar both hosts parse 2026-08-15 20:39:21 +05:30
pj e62b08dffd test(browser): compare ax.find across both hosts on one page 2026-08-15 20:39:18 +05:30