Files
sanderling/internal/bundler/bundler_test.go
T
pj 94d9511312 test: full test-suite refactor sweep (#61)
* chore(test): start test-suite refactor sweep

* test(ltl): pin exact multi-obligation residual AST

* test(ltl): table-test finalize Kleene connective combinations

* test(ltl): pin reduce over pending inner for bound, Or, Not

* test(ltl): marshal bounded Always steps/duration/deadline

* test(verifier): cover LTL combinator verdict transitions and within unit panic

* test(verifier): table-test DecodeAction kinds and lastAction field exposure

* test(verifier): assert WithPlatform(ios) reaches the picker host and key pool

* test(verifier): widen weighted-selection assertion to a 5x skew margin

* test(verifier): un-skip ax-find round trip with a committed tree fixture

* test(runner): pin isWDADrop to sidecar reconnect-failed message origin

* test(runner): assert PressKey/Wait trace encoding records kind-specific fields

* test(runner): cover RenderSummary unsupported-verbs surfacing branch

* test(trace): set Hierarchy in round-trip and lock lossy Tree contract

Also add a -race concurrent WriteStep test that asserts N well-formed JSONL lines, catching torn lines if the writer mutex is dropped.

* test(trace): round-trip witnesses/changes/metrics/exceptions, pin step-0 witness

* test(trace): document ViolationsAreGreppable grep contract and lock-free WriteScreenshot

* test(hierarchy): cover invalid-JSON and malformed-bounds parser paths

* test(trace): guard writer mutex via WriteStep/Close race on w.file

* test(replay): drop unfailable assets and devproxy assertions

* test(replay): cache reuses on equal mtime, reparses after append

* test(replay): violation marker falls back to detection step when attributed missing

* test(replay): corrupt meta/trace dirs return 500 with error body

* test(replay): SSE client receives runs.changed after a broadcast

* test(replay): Run coalesces creates, ignores write/chmod, closes subs on cancel

* fix(sidecar): synchronize health fixture writes and exercise healthError

* test(sidecar): cover swipe/longpress/doubletap/erase/presskey/metrics/logs translations

* test(sidecar): cover DoubleTapSelector composition and mid-gesture cancel

* test(sidecar): assert gRPC error status surfaces from action RPC

* fix(chrome): route action methods through runCtx so caller cancellation aborts CDP

* fix(chrome): route hierarchy/screenshot/waitidle/metrics through runCtx

* refactor(ios): extract pure simctl JSON parsers

* refactor(ios): add command-runner seams for EnsureSimulator

* test(ios): table-test simctl parsers and EnsureSimulator seams

* test(sidecarassets): cover placeholder build path

* test(sidecarassets): assert reuse via sentinel bytes not mtime

* test(bundler): cover properties-only spec registration

* refactor(testrun): extract prepareBundleInputs from Execute

* test(testrun): cover prepareBundleInputs aliases and missing-runtime error

* test(testrun): table-test resolveRuntimeSibling search edges

* test(testrun): exact-output tests for progressHandler line format

* fix(cmd): point bundle-check aliases at pkg/spec/src

* test(cmd): smoke-test bundle-check resolves spec aliases

* test(cmd): table-test hier-check parse and FindAll on fixture

* test(cmd): unit-test buildBrowseURL deep-link vs root

* test(cmd): drop flaky TestRun_Doctor that launched real Chromium

* test(cmd): pin pipeline error to bundle resolution on web platform

* test(replay-ui): add bun test script

* ci(replay-ui): run bun test via make web-test target

* ci(replay-ui): point bun cache key at replay-ui/bun.lock

* test(replay-ui): exercise real URL encoding and non-ok throw in getJson

* refactor(replay-ui): extract snapshot flatten/getAtPath into lib module

* test(replay-ui): pin snapshot flatten/getAtPath path round-trip

* refactor(replay-ui): extract action selector/format into lib module

* test(replay-ui): pin action selector parse and row formatting

* refactor(replay-ui): share one statusFor between panels

* refactor(replay-ui): extract run-history derivation into lib module

* test(replay-ui): pin shared statusFor precedence and ordering

* test(replay-ui): pin run-history derivation alignment

* refactor(replay-ui): export clampIndex for testing

* refactor(replay-ui): extract keyboard-nav dispatch into pure module

* refactor(replay-ui): extract metrics formatters into lib module

* test(replay-ui): pin clampIndex step boundaries

* test(replay-ui): pin keyboard-nav ownership and key routing

* test(replay-ui): pin metrics formatters and path gap handling

* refactor(sidecar): expose device-output parsers as internal for testing

* test(sidecar): table-test device-output parsers against malformed input

* test(sidecar): cover logcat parsing year inference and line skipping

* test(sidecar): pin pressKey keycode mapping and unknown-key rejection

* test(sidecar): metrics bundleId falls back to launched app and honors override

* test(sidecar): loosen deadline upper bound to tolerate slow CI scheduling

* test(web-runtime): export selector builders for unit tests

* test(web-runtime): guard sanitize cycle, function, and depth limits

* test(web-runtime): table-test selector builder quoting and escaping

* test(sidecar): collapse scalar-forwarding RPC tests into a table

* test(replay-ui): dedup step/summary fixtures into shared module

* test(ios): collapse pickSimulator point-tests into a table
2026-06-06 13:59:08 +05:30

268 lines
7.9 KiB
Go

package bundler
import (
"os"
"path/filepath"
"strings"
"testing"
)
func writeFixture(t *testing.T, name, contents string) string {
t.Helper()
directory := t.TempDir()
path := filepath.Join(directory, name)
if err := os.WriteFile(path, []byte(contents), 0o600); err != nil {
t.Fatal(err)
}
return path
}
func TestBundle_RequiresEntryFile(t *testing.T) {
_, err := Bundle(Options{})
if err == nil || !strings.Contains(err.Error(), "EntryFile") {
t.Fatalf("expected EntryFile error, got %v", err)
}
}
func TestBundle_ProducesIIFE(t *testing.T) {
entry := writeFixture(t, "spec.ts", `
const greeting: string = "hello";
console.log(greeting);
`)
result, err := Bundle(Options{EntryFile: entry})
if err != nil {
t.Fatal(err)
}
body := string(result.JavaScript)
if !strings.Contains(body, "(() =>") && !strings.Contains(body, "(function") {
t.Errorf("expected IIFE wrapping, got: %s", body)
}
if !strings.Contains(body, "hello") {
t.Errorf("expected literal to survive bundling: %s", body)
}
if result.SHA256 == "" {
t.Errorf("expected non-empty SHA256")
}
}
func TestBundle_InlinesDefines(t *testing.T) {
entry := writeFixture(t, "spec.ts", `
const phone = process.env.SANDERLING_TEST_PHONE;
const otp = process.env.SANDERLING_TEST_OTP;
export const credentials = { phone, otp };
`)
result, err := Bundle(Options{
EntryFile: entry,
Defines: map[string]string{
"SANDERLING_TEST_PHONE": "+919876543210",
"SANDERLING_TEST_OTP": "123456",
},
})
if err != nil {
t.Fatal(err)
}
body := string(result.JavaScript)
if !strings.Contains(body, "+919876543210") {
t.Errorf("phone define not inlined: %s", body)
}
if !strings.Contains(body, "123456") {
t.Errorf("otp define not inlined: %s", body)
}
}
func TestBundle_DeterministicHash(t *testing.T) {
entry := writeFixture(t, "spec.ts", `export const x = 1;`)
first, err := Bundle(Options{EntryFile: entry})
if err != nil {
t.Fatal(err)
}
second, err := Bundle(Options{EntryFile: entry})
if err != nil {
t.Fatal(err)
}
if first.SHA256 != second.SHA256 {
t.Errorf("hash should be stable: %s vs %s", first.SHA256, second.SHA256)
}
}
func TestBundle_HashChangesWithDefines(t *testing.T) {
entry := writeFixture(t, "spec.ts", `
export const phone = process.env.SANDERLING_TEST_PHONE;
`)
first, err := Bundle(Options{EntryFile: entry, Defines: map[string]string{"SANDERLING_TEST_PHONE": "1111"}})
if err != nil {
t.Fatal(err)
}
second, err := Bundle(Options{EntryFile: entry, Defines: map[string]string{"SANDERLING_TEST_PHONE": "2222"}})
if err != nil {
t.Fatal(err)
}
if first.SHA256 == second.SHA256 {
t.Errorf("hash should change when defines change")
}
}
func TestBundle_DefineEscapesJSONSpecialChars(t *testing.T) {
entry := writeFixture(t, "spec.ts", `
export const value = process.env.WEIRD;
`)
result, err := Bundle(Options{
EntryFile: entry,
Defines: map[string]string{"WEIRD": `quote " backslash \ newline`},
})
if err != nil {
t.Fatal(err)
}
// esbuild may pick single or double quoting; just confirm the meaningful
// fragments survive bundling intact.
body := string(result.JavaScript)
for _, fragment := range []string{`quote `, `backslash `, `newline`} {
if !strings.Contains(body, fragment) {
t.Errorf("missing fragment %q in bundle:\n%s", fragment, body)
}
}
}
func TestBundle_ImportResolution(t *testing.T) {
directory := t.TempDir()
helperPath := filepath.Join(directory, "helper.ts")
entryPath := filepath.Join(directory, "entry.ts")
if err := os.WriteFile(helperPath, []byte(`export const helperValue = 42;`), 0o600); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(entryPath, []byte(`
import { helperValue } from "./helper";
console.log(helperValue);
`), 0o600); err != nil {
t.Fatal(err)
}
result, err := Bundle(Options{EntryFile: entryPath})
if err != nil {
t.Fatal(err)
}
if !strings.Contains(string(result.JavaScript), "42") {
t.Errorf("imported value should be inlined: %s", result.JavaScript)
}
}
func TestBundle_RegistersNamedExportsOnGlobalThis(t *testing.T) {
directory := t.TempDir()
runtimePath := filepath.Join(directory, "runtime.ts")
specPath := filepath.Join(directory, "spec.ts")
if err := os.WriteFile(runtimePath, []byte(`export {};`), 0o600); err != nil {
t.Fatal(err)
}
spec := `
export const properties = "PROPS_MARKER";
export const actionsRoot = "ACTIONS_MARKER";
export const setup = "SETUP_MARKER";
`
if err := os.WriteFile(specPath, []byte(spec), 0o600); err != nil {
t.Fatal(err)
}
result, err := Bundle(Options{EntryFile: specPath, RuntimeFile: runtimePath})
if err != nil {
t.Fatal(err)
}
body := string(result.JavaScript)
for _, marker := range []string{"PROPS_MARKER", "ACTIONS_MARKER", "SETUP_MARKER"} {
if !strings.Contains(body, marker) {
t.Errorf("named export %q not registered in bundle:\n%s", marker, body)
}
}
if !strings.Contains(body, "globalThis.actions") {
t.Errorf("trailer should assign globalThis.actions:\n%s", body)
}
}
func TestBundle_RegistersWithoutSetupExport(t *testing.T) {
directory := t.TempDir()
runtimePath := filepath.Join(directory, "runtime.ts")
specPath := filepath.Join(directory, "spec.ts")
if err := os.WriteFile(runtimePath, []byte(`export {};`), 0o600); err != nil {
t.Fatal(err)
}
spec := `
export const properties = "PROPS_MARKER";
export const actionsRoot = "ACTIONS_MARKER";
`
if err := os.WriteFile(specPath, []byte(spec), 0o600); err != nil {
t.Fatal(err)
}
result, err := Bundle(Options{EntryFile: specPath, RuntimeFile: runtimePath})
if err != nil {
t.Fatalf("spec without setup export should still bundle: %v", err)
}
if !strings.Contains(string(result.JavaScript), "PROPS_MARKER") {
t.Errorf("properties export not registered")
}
}
func TestBundle_RegistersPropertiesOnlySpec(t *testing.T) {
directory := t.TempDir()
runtimePath := filepath.Join(directory, "runtime.ts")
specPath := filepath.Join(directory, "spec.ts")
if err := os.WriteFile(runtimePath, []byte(`export {};`), 0o600); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(specPath, []byte(`export const properties = "PROPS_MARKER";`), 0o600); err != nil {
t.Fatal(err)
}
result, err := Bundle(Options{EntryFile: specPath, RuntimeFile: runtimePath})
if err != nil {
t.Fatalf("properties-only spec should bundle: %v", err)
}
body := string(result.JavaScript)
if !strings.Contains(body, "PROPS_MARKER") {
t.Errorf("properties export not registered:\n%s", body)
}
if !strings.Contains(body, "globalThis.properties") {
t.Errorf("trailer should assign globalThis.properties:\n%s", body)
}
}
func TestBundle_ReportsSyntaxErrors(t *testing.T) {
entry := writeFixture(t, "broken.ts", `const x = ;`)
_, err := Bundle(Options{EntryFile: entry})
if err == nil || !strings.Contains(err.Error(), "bundle failed") {
t.Errorf("expected bundle failure, got %v", err)
}
}
func TestBundle_SourcemapInlinedWhenRequested(t *testing.T) {
entry := writeFixture(t, "spec.ts", `export const x = 1;`)
result, err := Bundle(Options{EntryFile: entry, Sourcemap: true})
if err != nil {
t.Fatal(err)
}
if !strings.Contains(string(result.JavaScript), "sourceMappingURL") {
t.Errorf("expected inline sourcemap")
}
}
func TestBundle_AliasResolvesPackageImport(t *testing.T) {
directory := t.TempDir()
aliasTarget := filepath.Join(directory, "aliased.ts")
entryPath := filepath.Join(directory, "entry.ts")
if err := os.WriteFile(aliasTarget, []byte(`export const aliasMagic = "alias-resolved";`), 0o600); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(entryPath, []byte(`
import { aliasMagic } from "@example/aliased";
console.log(aliasMagic);
`), 0o600); err != nil {
t.Fatal(err)
}
result, err := Bundle(Options{
EntryFile: entryPath,
Aliases: map[string]string{"@example/aliased": aliasTarget},
})
if err != nil {
t.Fatal(err)
}
if !strings.Contains(string(result.JavaScript), "alias-resolved") {
t.Errorf("alias target should be inlined: %s", result.JavaScript)
}
}