mirror of
https://github.com/priyanshujain/sanderling.git
synced 2026-10-02 19:17:10 +00:00
fix(ltl): eliminate implies and bounded-always false-negatives
Rewrite a -> b to (not a) or b in NNF so a pending temporal antecedent can no longer defer the whole implication and drop a consequent that was false at the current step. Carry a pending inner past a bounded-Always window close instead of dropping it to holds, so a deferred obligation is resolved by a later step or Finalize.
This commit is contained in:
1 parent
283bf44920
commit
1834019419
2 files changed
+27
-19
No files matched your search
+20
-16
@@ -347,18 +347,14 @@ func reduce(formula Formula, now time.Time) reduceResult {
|
||||
return pending(next)
|
||||
|
||||
case ImpliesFormula:
|
||||
antecedent := reduce(concrete.Antecedent, now)
|
||||
switch antecedent.status {
|
||||
case statusHolds:
|
||||
return reduce(concrete.Consequent, now)
|
||||
case statusViolated:
|
||||
return holds()
|
||||
case statusPending:
|
||||
return pending(ImpliesFormula{
|
||||
Antecedent: antecedent.formula,
|
||||
Consequent: concrete.Consequent,
|
||||
})
|
||||
}
|
||||
// NewEvaluator runs nnf, which rewrites a -> b to (not a) or b, so this
|
||||
// case is unreachable from a normal evaluator. A directly-constructed
|
||||
// formula reduced here is evaluated through the same equivalence so a
|
||||
// pending antecedent cannot drop the consequent.
|
||||
return reduce(OrFormula{
|
||||
Left: pushNot(concrete.Antecedent),
|
||||
Right: nnf(concrete.Consequent),
|
||||
}, now)
|
||||
|
||||
case OrFormula:
|
||||
left := reduce(concrete.Left, now)
|
||||
@@ -420,13 +416,21 @@ func reduce(formula Formula, now time.Time) reduceResult {
|
||||
return violatedFrom(innerResult, concrete, "always inner violated")
|
||||
}
|
||||
// A bounded Always is the dual of a bounded Eventually: once the window
|
||||
// closes without a breach it is vacuously satisfied. At the last step in
|
||||
// the window a pending inner cannot be deferred, so it resolves to holds.
|
||||
// closes without a breach it is vacuously satisfied. A pending inner at
|
||||
// the closing step is a deferred obligation (a strong next, or an inner
|
||||
// liveness that has not discharged); it must be carried so a later step
|
||||
// or Finalize resolves it, never dropped to holds.
|
||||
if concrete.HasStepBound && concrete.StepBound <= 1 {
|
||||
return holds()
|
||||
if innerResult.status == statusHolds {
|
||||
return holds()
|
||||
}
|
||||
return pending(innerResult.formula)
|
||||
}
|
||||
if concrete.HasDeadline && !now.Before(concrete.Deadline) {
|
||||
return holds()
|
||||
if innerResult.status == statusHolds {
|
||||
return holds()
|
||||
}
|
||||
return pending(innerResult.formula)
|
||||
}
|
||||
next := concrete
|
||||
next.Inner = concrete.Inner
|
||||
|
||||
+7
-3
@@ -26,9 +26,13 @@ func nnf(formula Formula) Formula {
|
||||
case OrFormula:
|
||||
return OrFormula{Left: nnf(concrete.Left), Right: nnf(concrete.Right)}
|
||||
case ImpliesFormula:
|
||||
return ImpliesFormula{
|
||||
Antecedent: nnf(concrete.Antecedent),
|
||||
Consequent: nnf(concrete.Consequent),
|
||||
// a -> b is rewritten to (not a) or b so the consequent is always
|
||||
// reduced live each step. Keeping it as ImpliesFormula let a pending
|
||||
// (temporal) antecedent defer the whole implication and silently drop a
|
||||
// consequent that was false at the current step.
|
||||
return OrFormula{
|
||||
Left: pushNot(concrete.Antecedent),
|
||||
Right: nnf(concrete.Consequent),
|
||||
}
|
||||
default:
|
||||
return formula
|
||||
|
||||
Reference in new issue
Block a user