mirror of
https://github.com/priyanshujain/sanderling.git
synced 2026-10-03 03:27:10 +00:00
* chore(test): start test-suite refactor sweep * test(ltl): pin exact multi-obligation residual AST * test(ltl): table-test finalize Kleene connective combinations * test(ltl): pin reduce over pending inner for bound, Or, Not * test(ltl): marshal bounded Always steps/duration/deadline * test(verifier): cover LTL combinator verdict transitions and within unit panic * test(verifier): table-test DecodeAction kinds and lastAction field exposure * test(verifier): assert WithPlatform(ios) reaches the picker host and key pool * test(verifier): widen weighted-selection assertion to a 5x skew margin * test(verifier): un-skip ax-find round trip with a committed tree fixture * test(runner): pin isWDADrop to sidecar reconnect-failed message origin * test(runner): assert PressKey/Wait trace encoding records kind-specific fields * test(runner): cover RenderSummary unsupported-verbs surfacing branch * test(trace): set Hierarchy in round-trip and lock lossy Tree contract Also add a -race concurrent WriteStep test that asserts N well-formed JSONL lines, catching torn lines if the writer mutex is dropped. * test(trace): round-trip witnesses/changes/metrics/exceptions, pin step-0 witness * test(trace): document ViolationsAreGreppable grep contract and lock-free WriteScreenshot * test(hierarchy): cover invalid-JSON and malformed-bounds parser paths * test(trace): guard writer mutex via WriteStep/Close race on w.file * test(replay): drop unfailable assets and devproxy assertions * test(replay): cache reuses on equal mtime, reparses after append * test(replay): violation marker falls back to detection step when attributed missing * test(replay): corrupt meta/trace dirs return 500 with error body * test(replay): SSE client receives runs.changed after a broadcast * test(replay): Run coalesces creates, ignores write/chmod, closes subs on cancel * fix(sidecar): synchronize health fixture writes and exercise healthError * test(sidecar): cover swipe/longpress/doubletap/erase/presskey/metrics/logs translations * test(sidecar): cover DoubleTapSelector composition and mid-gesture cancel * test(sidecar): assert gRPC error status surfaces from action RPC * fix(chrome): route action methods through runCtx so caller cancellation aborts CDP * fix(chrome): route hierarchy/screenshot/waitidle/metrics through runCtx * refactor(ios): extract pure simctl JSON parsers * refactor(ios): add command-runner seams for EnsureSimulator * test(ios): table-test simctl parsers and EnsureSimulator seams * test(sidecarassets): cover placeholder build path * test(sidecarassets): assert reuse via sentinel bytes not mtime * test(bundler): cover properties-only spec registration * refactor(testrun): extract prepareBundleInputs from Execute * test(testrun): cover prepareBundleInputs aliases and missing-runtime error * test(testrun): table-test resolveRuntimeSibling search edges * test(testrun): exact-output tests for progressHandler line format * fix(cmd): point bundle-check aliases at pkg/spec/src * test(cmd): smoke-test bundle-check resolves spec aliases * test(cmd): table-test hier-check parse and FindAll on fixture * test(cmd): unit-test buildBrowseURL deep-link vs root * test(cmd): drop flaky TestRun_Doctor that launched real Chromium * test(cmd): pin pipeline error to bundle resolution on web platform * test(replay-ui): add bun test script * ci(replay-ui): run bun test via make web-test target * ci(replay-ui): point bun cache key at replay-ui/bun.lock * test(replay-ui): exercise real URL encoding and non-ok throw in getJson * refactor(replay-ui): extract snapshot flatten/getAtPath into lib module * test(replay-ui): pin snapshot flatten/getAtPath path round-trip * refactor(replay-ui): extract action selector/format into lib module * test(replay-ui): pin action selector parse and row formatting * refactor(replay-ui): share one statusFor between panels * refactor(replay-ui): extract run-history derivation into lib module * test(replay-ui): pin shared statusFor precedence and ordering * test(replay-ui): pin run-history derivation alignment * refactor(replay-ui): export clampIndex for testing * refactor(replay-ui): extract keyboard-nav dispatch into pure module * refactor(replay-ui): extract metrics formatters into lib module * test(replay-ui): pin clampIndex step boundaries * test(replay-ui): pin keyboard-nav ownership and key routing * test(replay-ui): pin metrics formatters and path gap handling * refactor(sidecar): expose device-output parsers as internal for testing * test(sidecar): table-test device-output parsers against malformed input * test(sidecar): cover logcat parsing year inference and line skipping * test(sidecar): pin pressKey keycode mapping and unknown-key rejection * test(sidecar): metrics bundleId falls back to launched app and honors override * test(sidecar): loosen deadline upper bound to tolerate slow CI scheduling * test(web-runtime): export selector builders for unit tests * test(web-runtime): guard sanitize cycle, function, and depth limits * test(web-runtime): table-test selector builder quoting and escaping * test(sidecar): collapse scalar-forwarding RPC tests into a table * test(replay-ui): dedup step/summary fixtures into shared module * test(ios): collapse pickSimulator point-tests into a table
104 lines
3.6 KiB
TypeScript
104 lines
3.6 KiB
TypeScript
import { describe, it, expect } from "bun:test";
|
|
import {
|
|
dispatchKey,
|
|
targetOwnsArrowKeys,
|
|
type KeyboardNavOptions,
|
|
} from "../lib/keyboard-nav";
|
|
|
|
function el(
|
|
over: Partial<{
|
|
tagName: string;
|
|
isContentEditable: boolean;
|
|
role: string | null;
|
|
parent: HTMLElement | null;
|
|
}> = {},
|
|
): HTMLElement {
|
|
const role = over.role ?? null;
|
|
return {
|
|
tagName: over.tagName ?? "DIV",
|
|
isContentEditable: over.isContentEditable ?? false,
|
|
getAttribute: (name: string) => (name === "role" ? role : null),
|
|
parentElement: over.parent ?? null,
|
|
} as unknown as HTMLElement;
|
|
}
|
|
|
|
function spyOptions() {
|
|
const calls: string[] = [];
|
|
const make = (name: keyof KeyboardNavOptions) => () => {
|
|
calls.push(name);
|
|
};
|
|
const options: KeyboardNavOptions = {
|
|
onPrev: make("onPrev"),
|
|
onNext: make("onNext"),
|
|
onJumpStart: make("onJumpStart"),
|
|
onJumpEnd: make("onJumpEnd"),
|
|
onJumpPrev10: make("onJumpPrev10"),
|
|
onJumpNext10: make("onJumpNext10"),
|
|
onJumpNextViolation: make("onJumpNextViolation"),
|
|
};
|
|
return { calls, options };
|
|
}
|
|
|
|
describe("targetOwnsArrowKeys", () => {
|
|
it("walks ancestors and matches arrow-owning roles", () => {
|
|
expect(targetOwnsArrowKeys(el({ role: "option" }))).toBe(true);
|
|
const child = el({ role: null, parent: el({ role: "listbox" }) });
|
|
expect(targetOwnsArrowKeys(child)).toBe(true);
|
|
expect(targetOwnsArrowKeys(el({ role: "banner" }))).toBe(false);
|
|
expect(targetOwnsArrowKeys(null)).toBe(false);
|
|
});
|
|
});
|
|
|
|
// Bug class: navigation keys firing while the user types in a form field would
|
|
// scrub the timeline out from under them; and arrow keys must yield to a
|
|
// listbox/tab that owns them so its own roving focus still works.
|
|
describe("dispatchKey ownership", () => {
|
|
it("ignores keys originating in editable targets", () => {
|
|
const { calls, options } = spyOptions();
|
|
expect(dispatchKey({ key: "j", target: el({ tagName: "INPUT" }) }, options)).toBe(false);
|
|
expect(dispatchKey({ key: "g", target: el({ isContentEditable: true }) }, options)).toBe(false);
|
|
expect(calls).toEqual([]);
|
|
});
|
|
|
|
it("yields arrow keys to an owning ancestor but still handles letters", () => {
|
|
const { calls, options } = spyOptions();
|
|
const inListbox = el({ parent: el({ role: "listbox" }) });
|
|
expect(dispatchKey({ key: "ArrowRight", target: inListbox }, options)).toBe(false);
|
|
expect(dispatchKey({ key: "j", target: inListbox }, options)).toBe(true);
|
|
expect(calls).toEqual(["onNext"]);
|
|
});
|
|
|
|
it("ignores keys combined with a modifier", () => {
|
|
const { calls, options } = spyOptions();
|
|
expect(dispatchKey({ key: "j", metaKey: true }, options)).toBe(false);
|
|
expect(dispatchKey({ key: "j", ctrlKey: true }, options)).toBe(false);
|
|
expect(calls).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe("dispatchKey routing", () => {
|
|
const cases: [string, boolean, keyof KeyboardNavOptions][] = [
|
|
["ArrowLeft", false, "onPrev"],
|
|
["k", false, "onPrev"],
|
|
["ArrowLeft", true, "onJumpPrev10"],
|
|
["ArrowRight", false, "onNext"],
|
|
["j", true, "onJumpNext10"],
|
|
["g", false, "onJumpStart"],
|
|
["G", false, "onJumpEnd"],
|
|
[".", false, "onJumpNextViolation"],
|
|
];
|
|
for (const [key, shiftKey, expected] of cases) {
|
|
it(`${shiftKey ? "shift+" : ""}${key} -> ${expected}`, () => {
|
|
const { calls, options } = spyOptions();
|
|
expect(dispatchKey({ key, shiftKey }, options)).toBe(true);
|
|
expect(calls).toEqual([expected]);
|
|
});
|
|
}
|
|
|
|
it("leaves unmapped keys untouched", () => {
|
|
const { calls, options } = spyOptions();
|
|
expect(dispatchKey({ key: "x" }, options)).toBe(false);
|
|
expect(calls).toEqual([]);
|
|
});
|
|
});
|