Files
sanderling/replay-ui/src/routes/RunDetail.tsx
T
pj 94d9511312 test: full test-suite refactor sweep (#61)
* chore(test): start test-suite refactor sweep

* test(ltl): pin exact multi-obligation residual AST

* test(ltl): table-test finalize Kleene connective combinations

* test(ltl): pin reduce over pending inner for bound, Or, Not

* test(ltl): marshal bounded Always steps/duration/deadline

* test(verifier): cover LTL combinator verdict transitions and within unit panic

* test(verifier): table-test DecodeAction kinds and lastAction field exposure

* test(verifier): assert WithPlatform(ios) reaches the picker host and key pool

* test(verifier): widen weighted-selection assertion to a 5x skew margin

* test(verifier): un-skip ax-find round trip with a committed tree fixture

* test(runner): pin isWDADrop to sidecar reconnect-failed message origin

* test(runner): assert PressKey/Wait trace encoding records kind-specific fields

* test(runner): cover RenderSummary unsupported-verbs surfacing branch

* test(trace): set Hierarchy in round-trip and lock lossy Tree contract

Also add a -race concurrent WriteStep test that asserts N well-formed JSONL lines, catching torn lines if the writer mutex is dropped.

* test(trace): round-trip witnesses/changes/metrics/exceptions, pin step-0 witness

* test(trace): document ViolationsAreGreppable grep contract and lock-free WriteScreenshot

* test(hierarchy): cover invalid-JSON and malformed-bounds parser paths

* test(trace): guard writer mutex via WriteStep/Close race on w.file

* test(replay): drop unfailable assets and devproxy assertions

* test(replay): cache reuses on equal mtime, reparses after append

* test(replay): violation marker falls back to detection step when attributed missing

* test(replay): corrupt meta/trace dirs return 500 with error body

* test(replay): SSE client receives runs.changed after a broadcast

* test(replay): Run coalesces creates, ignores write/chmod, closes subs on cancel

* fix(sidecar): synchronize health fixture writes and exercise healthError

* test(sidecar): cover swipe/longpress/doubletap/erase/presskey/metrics/logs translations

* test(sidecar): cover DoubleTapSelector composition and mid-gesture cancel

* test(sidecar): assert gRPC error status surfaces from action RPC

* fix(chrome): route action methods through runCtx so caller cancellation aborts CDP

* fix(chrome): route hierarchy/screenshot/waitidle/metrics through runCtx

* refactor(ios): extract pure simctl JSON parsers

* refactor(ios): add command-runner seams for EnsureSimulator

* test(ios): table-test simctl parsers and EnsureSimulator seams

* test(sidecarassets): cover placeholder build path

* test(sidecarassets): assert reuse via sentinel bytes not mtime

* test(bundler): cover properties-only spec registration

* refactor(testrun): extract prepareBundleInputs from Execute

* test(testrun): cover prepareBundleInputs aliases and missing-runtime error

* test(testrun): table-test resolveRuntimeSibling search edges

* test(testrun): exact-output tests for progressHandler line format

* fix(cmd): point bundle-check aliases at pkg/spec/src

* test(cmd): smoke-test bundle-check resolves spec aliases

* test(cmd): table-test hier-check parse and FindAll on fixture

* test(cmd): unit-test buildBrowseURL deep-link vs root

* test(cmd): drop flaky TestRun_Doctor that launched real Chromium

* test(cmd): pin pipeline error to bundle resolution on web platform

* test(replay-ui): add bun test script

* ci(replay-ui): run bun test via make web-test target

* ci(replay-ui): point bun cache key at replay-ui/bun.lock

* test(replay-ui): exercise real URL encoding and non-ok throw in getJson

* refactor(replay-ui): extract snapshot flatten/getAtPath into lib module

* test(replay-ui): pin snapshot flatten/getAtPath path round-trip

* refactor(replay-ui): extract action selector/format into lib module

* test(replay-ui): pin action selector parse and row formatting

* refactor(replay-ui): share one statusFor between panels

* refactor(replay-ui): extract run-history derivation into lib module

* test(replay-ui): pin shared statusFor precedence and ordering

* test(replay-ui): pin run-history derivation alignment

* refactor(replay-ui): export clampIndex for testing

* refactor(replay-ui): extract keyboard-nav dispatch into pure module

* refactor(replay-ui): extract metrics formatters into lib module

* test(replay-ui): pin clampIndex step boundaries

* test(replay-ui): pin keyboard-nav ownership and key routing

* test(replay-ui): pin metrics formatters and path gap handling

* refactor(sidecar): expose device-output parsers as internal for testing

* test(sidecar): table-test device-output parsers against malformed input

* test(sidecar): cover logcat parsing year inference and line skipping

* test(sidecar): pin pressKey keycode mapping and unknown-key rejection

* test(sidecar): metrics bundleId falls back to launched app and honors override

* test(sidecar): loosen deadline upper bound to tolerate slow CI scheduling

* test(web-runtime): export selector builders for unit tests

* test(web-runtime): guard sanitize cycle, function, and depth limits

* test(web-runtime): table-test selector builder quoting and escaping

* test(sidecar): collapse scalar-forwarding RPC tests into a table

* test(replay-ui): dedup step/summary fixtures into shared module

* test(ios): collapse pickSimulator point-tests into a table
2026-06-06 13:59:08 +05:30

366 lines
12 KiB
TypeScript

import { useCallback, useEffect, useMemo, useState } from "react";
import { Link } from "react-router-dom";
import { getRun, getStep, screenshotUrl } from "../api";
import type { Run } from "../types";
import ActionList from "../panels/ActionList";
import HierarchyPanel from "../panels/HierarchyPanel";
import Screenshot from "../panels/Screenshot";
import SnapshotTable from "../panels/SnapshotTable";
import ViolationsPanel from "../panels/ViolationsPanel";
import ExceptionsPanel from "../panels/ExceptionsPanel";
import MetricsChart from "../panels/MetricsChart";
import Tabs, { type TabDefinition } from "../components/Tabs";
import { useStep } from "../hooks/useStep";
import { useKeyboardNav } from "../hooks/useKeyboardNav";
import { useTheme } from "../hooks/useTheme";
import { deviceSpaceOf } from "../lib/device-space";
import { buildRunHistory, type RunHistory } from "../lib/run-history";
function basename(specPath: string): string {
const index = specPath.lastIndexOf("/");
return index >= 0 ? specPath.slice(index + 1) : specPath;
}
export default function RunDetail() {
const [run, setRun] = useState<Run | null>(null);
const [history, setHistory] = useState<RunHistory | null>(null);
const [error, setError] = useState<string | null>(null);
const { theme, toggle } = useTheme();
const stepCount = run?.steps.length;
const { runId, stepIndex, goTo } = useStep(stepCount);
useEffect(() => {
if (!runId) return;
let cancelled = false;
setRun(null);
setHistory(null);
setError(null);
getRun(runId)
.then(async (loaded) => {
if (cancelled) return;
setRun(loaded);
const computed = await loadHistory(loaded);
if (!cancelled) {
setHistory(computed);
}
})
.catch((failure: unknown) => {
if (!cancelled) {
setError(failure instanceof Error ? failure.message : String(failure));
}
});
return () => {
cancelled = true;
};
}, [runId]);
const currentStep = history?.steps[stepIndex - 1] ?? null;
const previousStep = stepIndex > 1 ? history?.steps[stepIndex - 2] ?? null : null;
const nextStep = history && stepIndex < history.steps.length ? history.steps[stepIndex] ?? null : null;
const jumpToFirstViolation = useCallback(() => {
if (history?.firstViolationStep) {
goTo(history.firstViolationStep);
}
}, [history, goTo]);
const jumpToFirstException = useCallback(() => {
if (history?.firstExceptionStep) {
goTo(history.firstExceptionStep);
}
}, [history, goTo]);
const jumpToNextViolation = useCallback(() => {
if (!run) return;
const next = run.steps.find((entry) => entry.index > stepIndex && entry.has_violations);
if (next) goTo(next.index);
}, [run, stepIndex, goTo]);
useKeyboardNav({
onPrev: () => goTo(stepIndex - 1),
onNext: () => goTo(stepIndex + 1),
onJumpStart: () => goTo(1),
onJumpEnd: () => stepCount && goTo(stepCount),
onJumpPrev10: () => goTo(stepIndex - 10),
onJumpNext10: () => goTo(stepIndex + 10),
onJumpNextViolation: jumpToNextViolation,
});
// One screenshot per step depicts the UI at observation time (post-prior-
// action, post-settle). The "after" view for step N is therefore step
// (N+1)'s screenshot: the same moment, observed from the next iteration.
const beforeScreenshot = useMemo(() => {
if (!runId || !currentStep) return undefined;
return screenshotUrl(runId, `step-${String(currentStep.step).padStart(5, "0")}.png`);
}, [runId, currentStep]);
const afterScreenshot = useMemo(() => {
if (!runId || !nextStep) return undefined;
return screenshotUrl(runId, `step-${String(nextStep.step).padStart(5, "0")}.png`);
}, [runId, nextStep]);
const runStartMillis = useMemo(() => {
if (!run?.steps.length) return 0;
return new Date(run.steps[0].timestamp).getTime();
}, [run]);
if (error) {
return <div className="status-block status-error">failed: {error}</div>;
}
if (!run) {
return <div className="status-block">loading run...</div>;
}
const violationsBefore = currentStep?.violations ?? [];
const violationsAfter = nextStep?.violations ?? violationsBefore;
const residualsBefore = currentStep?.residuals;
const residualsAfter = nextStep?.residuals ?? residualsBefore;
const witnessesBefore = currentStep?.witnesses;
const witnessesAfter = nextStep?.witnesses ?? witnessesBefore;
const exceptionsForStep = currentStep?.exceptions;
const beforeSpace = deviceSpaceOf(currentStep?.hierarchy);
const afterSpace = deviceSpaceOf(nextStep?.hierarchy ?? currentStep?.hierarchy);
const beforeTabs: TabDefinition[] = [
{
id: "screenshot",
label: "Screenshot",
content: (
<Screenshot
src={beforeScreenshot}
action={currentStep?.next_action}
deviceWidth={beforeSpace?.width}
deviceHeight={beforeSpace?.height}
/>
),
},
{
id: "snapshots",
label: "Snapshots",
content: (
<SnapshotTable
snapshots={currentStep?.snapshots}
previousSnapshots={previousStep?.snapshots ?? undefined}
/>
),
},
{
id: "hierarchy",
label: "Hierarchy",
content: <HierarchyPanel hierarchy={currentStep?.hierarchy} />,
},
{
id: "properties",
label: "Properties",
content: (
<ViolationsPanel
propertyNames={history?.names ?? []}
violations={violationsBefore}
residuals={residualsBefore}
witnesses={witnessesBefore}
onJumpToFirstViolation={jumpToFirstViolation}
hasFirstViolation={history?.firstViolationStep !== undefined}
onJumpToStep={goTo}
/>
),
},
{
id: "violations",
label: "Violations",
badge:
violationsBefore.length > 0 ? (
<span className="tabs-badge" data-kind="violation">
{violationsBefore.length}
</span>
) : undefined,
content: (
<ViolationsPanel
propertyNames={history?.names ?? []}
violations={violationsBefore}
residuals={residualsBefore}
witnesses={witnessesBefore}
onJumpToFirstViolation={jumpToFirstViolation}
hasFirstViolation={history?.firstViolationStep !== undefined}
onJumpToStep={goTo}
violationsOnly
/>
),
},
];
const afterTabs: TabDefinition[] = [
{
id: "screenshot",
label: "Screenshot",
content: (
<Screenshot
src={afterScreenshot}
action={undefined}
deviceWidth={afterSpace?.width}
deviceHeight={afterSpace?.height}
/>
),
},
{
id: "snapshots",
label: "Snapshots",
content: (
<SnapshotTable
snapshots={nextStep?.snapshots ?? currentStep?.snapshots}
previousSnapshots={currentStep?.snapshots ?? undefined}
/>
),
},
{
id: "hierarchy",
label: "Hierarchy",
content: <HierarchyPanel hierarchy={nextStep?.hierarchy ?? currentStep?.hierarchy} />,
},
{
id: "properties",
label: "Properties",
content: (
<ViolationsPanel
propertyNames={history?.names ?? []}
violations={violationsAfter}
residuals={residualsAfter}
witnesses={witnessesAfter}
onJumpToFirstViolation={jumpToFirstViolation}
hasFirstViolation={history?.firstViolationStep !== undefined}
onJumpToStep={goTo}
/>
),
},
{
id: "violations",
label: "Violations",
badge:
violationsAfter.length > 0 ? (
<span className="tabs-badge" data-kind="violation">
{violationsAfter.length}
</span>
) : undefined,
content: (
<ViolationsPanel
propertyNames={history?.names ?? []}
violations={violationsAfter}
residuals={residualsAfter}
witnesses={witnessesAfter}
onJumpToFirstViolation={jumpToFirstViolation}
hasFirstViolation={history?.firstViolationStep !== undefined}
onJumpToStep={goTo}
violationsOnly
/>
),
},
];
return (
<div className="detail-root">
<div className="detail-toolbar">
<div className="detail-toolbar-meta">
<Link to="/">runs</Link>
<span>{run.id}</span>
<span>
<strong title={run.spec_path}>{basename(run.spec_path)}</strong> seed={run.seed}
</span>
<span>
step {stepIndex} / {stepCount ?? 0}
</span>
</div>
<button
type="button"
className="theme-toggle"
onClick={toggle}
aria-label={theme === "dark" ? "switch to light theme" : "switch to dark theme"}
title={theme === "dark" ? "switch to light theme" : "switch to dark theme"}
>
{theme === "dark" ? (
<svg viewBox="0 0 16 16" width="14" height="14" aria-hidden="true" focusable="false">
<circle cx="8" cy="8" r="3" fill="none" stroke="currentColor" strokeWidth="1.25" />
<g stroke="currentColor" strokeWidth="1.25" strokeLinecap="round">
<line x1="8" y1="1.5" x2="8" y2="3.5" />
<line x1="8" y1="12.5" x2="8" y2="14.5" />
<line x1="1.5" y1="8" x2="3.5" y2="8" />
<line x1="12.5" y1="8" x2="14.5" y2="8" />
<line x1="3.4" y1="3.4" x2="4.8" y2="4.8" />
<line x1="11.2" y1="11.2" x2="12.6" y2="12.6" />
<line x1="3.4" y1="12.6" x2="4.8" y2="11.2" />
<line x1="11.2" y1="4.8" x2="12.6" y2="3.4" />
</g>
</svg>
) : (
<svg viewBox="0 0 16 16" width="14" height="14" aria-hidden="true" focusable="false">
<path
d="M13.2 9.8A5.2 5.2 0 0 1 6.2 2.8a5.2 5.2 0 1 0 7 7Z"
fill="none"
stroke="currentColor"
strokeWidth="1.25"
strokeLinejoin="round"
/>
</svg>
)}
</button>
</div>
<div className="detail-grid">
<aside className="detail-actions detail-panel">
<h2>actions</h2>
<div className="detail-panel-body">
<ActionList
steps={run.steps}
selectedIndex={stepIndex}
onSelect={goTo}
runStartMillis={runStartMillis}
selectedStep={currentStep ?? undefined}
/>
</div>
</aside>
<section className="detail-state-before detail-panel">
<h2>state before</h2>
<div className="detail-panel-body">
<Tabs tabs={beforeTabs} defaultTabId="screenshot" ariaLabel="state before" />
</div>
</section>
<section className="detail-state-after detail-panel">
<h2>state after</h2>
<div className="detail-panel-body">
<Tabs tabs={afterTabs} defaultTabId="screenshot" ariaLabel="state after" />
</div>
</section>
<section className="detail-metrics detail-panel">
<div className="detail-panel-body">
<MetricsChart
samples={history?.metricsSamples ?? []}
selectedIndex={stepIndex}
onSelect={goTo}
runStartMillis={runStartMillis}
/>
{(exceptionsForStep && exceptionsForStep.length > 0) ||
history?.firstExceptionStep !== undefined ? (
<div className="detail-metrics-exceptions">
<ExceptionsPanel
exceptions={exceptionsForStep}
onJumpToFirstException={jumpToFirstException}
hasFirstException={history?.firstExceptionStep !== undefined}
/>
</div>
) : null}
</div>
</section>
</div>
</div>
);
}
async function loadHistory(run: Run): Promise<RunHistory> {
const responses = await Promise.all(
run.steps.map((entry) => getStep(run.id, entry.index).catch(() => null)),
);
return buildRunHistory(run, responses);
}