mirror of
https://github.com/priyanshujain/sanderling.git
synced 2026-10-03 11:37:09 +00:00
* chore(test): start test-suite refactor sweep * test(ltl): pin exact multi-obligation residual AST * test(ltl): table-test finalize Kleene connective combinations * test(ltl): pin reduce over pending inner for bound, Or, Not * test(ltl): marshal bounded Always steps/duration/deadline * test(verifier): cover LTL combinator verdict transitions and within unit panic * test(verifier): table-test DecodeAction kinds and lastAction field exposure * test(verifier): assert WithPlatform(ios) reaches the picker host and key pool * test(verifier): widen weighted-selection assertion to a 5x skew margin * test(verifier): un-skip ax-find round trip with a committed tree fixture * test(runner): pin isWDADrop to sidecar reconnect-failed message origin * test(runner): assert PressKey/Wait trace encoding records kind-specific fields * test(runner): cover RenderSummary unsupported-verbs surfacing branch * test(trace): set Hierarchy in round-trip and lock lossy Tree contract Also add a -race concurrent WriteStep test that asserts N well-formed JSONL lines, catching torn lines if the writer mutex is dropped. * test(trace): round-trip witnesses/changes/metrics/exceptions, pin step-0 witness * test(trace): document ViolationsAreGreppable grep contract and lock-free WriteScreenshot * test(hierarchy): cover invalid-JSON and malformed-bounds parser paths * test(trace): guard writer mutex via WriteStep/Close race on w.file * test(replay): drop unfailable assets and devproxy assertions * test(replay): cache reuses on equal mtime, reparses after append * test(replay): violation marker falls back to detection step when attributed missing * test(replay): corrupt meta/trace dirs return 500 with error body * test(replay): SSE client receives runs.changed after a broadcast * test(replay): Run coalesces creates, ignores write/chmod, closes subs on cancel * fix(sidecar): synchronize health fixture writes and exercise healthError * test(sidecar): cover swipe/longpress/doubletap/erase/presskey/metrics/logs translations * test(sidecar): cover DoubleTapSelector composition and mid-gesture cancel * test(sidecar): assert gRPC error status surfaces from action RPC * fix(chrome): route action methods through runCtx so caller cancellation aborts CDP * fix(chrome): route hierarchy/screenshot/waitidle/metrics through runCtx * refactor(ios): extract pure simctl JSON parsers * refactor(ios): add command-runner seams for EnsureSimulator * test(ios): table-test simctl parsers and EnsureSimulator seams * test(sidecarassets): cover placeholder build path * test(sidecarassets): assert reuse via sentinel bytes not mtime * test(bundler): cover properties-only spec registration * refactor(testrun): extract prepareBundleInputs from Execute * test(testrun): cover prepareBundleInputs aliases and missing-runtime error * test(testrun): table-test resolveRuntimeSibling search edges * test(testrun): exact-output tests for progressHandler line format * fix(cmd): point bundle-check aliases at pkg/spec/src * test(cmd): smoke-test bundle-check resolves spec aliases * test(cmd): table-test hier-check parse and FindAll on fixture * test(cmd): unit-test buildBrowseURL deep-link vs root * test(cmd): drop flaky TestRun_Doctor that launched real Chromium * test(cmd): pin pipeline error to bundle resolution on web platform * test(replay-ui): add bun test script * ci(replay-ui): run bun test via make web-test target * ci(replay-ui): point bun cache key at replay-ui/bun.lock * test(replay-ui): exercise real URL encoding and non-ok throw in getJson * refactor(replay-ui): extract snapshot flatten/getAtPath into lib module * test(replay-ui): pin snapshot flatten/getAtPath path round-trip * refactor(replay-ui): extract action selector/format into lib module * test(replay-ui): pin action selector parse and row formatting * refactor(replay-ui): share one statusFor between panels * refactor(replay-ui): extract run-history derivation into lib module * test(replay-ui): pin shared statusFor precedence and ordering * test(replay-ui): pin run-history derivation alignment * refactor(replay-ui): export clampIndex for testing * refactor(replay-ui): extract keyboard-nav dispatch into pure module * refactor(replay-ui): extract metrics formatters into lib module * test(replay-ui): pin clampIndex step boundaries * test(replay-ui): pin keyboard-nav ownership and key routing * test(replay-ui): pin metrics formatters and path gap handling * refactor(sidecar): expose device-output parsers as internal for testing * test(sidecar): table-test device-output parsers against malformed input * test(sidecar): cover logcat parsing year inference and line skipping * test(sidecar): pin pressKey keycode mapping and unknown-key rejection * test(sidecar): metrics bundleId falls back to launched app and honors override * test(sidecar): loosen deadline upper bound to tolerate slow CI scheduling * test(web-runtime): export selector builders for unit tests * test(web-runtime): guard sanitize cycle, function, and depth limits * test(web-runtime): table-test selector builder quoting and escaping * test(sidecar): collapse scalar-forwarding RPC tests into a table * test(replay-ui): dedup step/summary fixtures into shared module * test(ios): collapse pickSimulator point-tests into a table
158 lines
5.2 KiB
TypeScript
158 lines
5.2 KiB
TypeScript
import { useMemo } from "react";
|
|
import type { ResidualNode, Witness } from "../types";
|
|
import { STATUS_ORDER, statusFor } from "../lib/property-status";
|
|
import ResidualNodeView from "../components/ResidualNode";
|
|
import "./ViolationsPanel.css";
|
|
|
|
export interface ViolationsPanelProps {
|
|
propertyNames: string[];
|
|
violations: string[];
|
|
residuals?: Record<string, ResidualNode>;
|
|
witnesses?: Record<string, Witness>;
|
|
onJumpToFirstViolation: () => void;
|
|
hasFirstViolation: boolean;
|
|
onJumpToStep?: (step: number) => void;
|
|
/** When true, only render violated rows and hide the header button row. */
|
|
violationsOnly?: boolean;
|
|
}
|
|
|
|
function formatValue(value: unknown): string {
|
|
const encoded = JSON.stringify(value);
|
|
return encoded === undefined ? String(value) : encoded;
|
|
}
|
|
|
|
function WitnessView({
|
|
witness,
|
|
onJumpToStep,
|
|
open,
|
|
}: {
|
|
witness: Witness;
|
|
onJumpToStep?: (step: number) => void;
|
|
open: boolean;
|
|
}) {
|
|
const evidence = Object.entries(witness.extractors ?? {})
|
|
.filter(([, value]) => value !== null && value !== undefined)
|
|
.sort(([a], [b]) => a.localeCompare(b));
|
|
return (
|
|
<div className="violations-panel-witness">
|
|
{witness.reason ? (
|
|
<div className="violations-panel-witness-line">
|
|
<span className="violations-panel-witness-key">
|
|
{witness.is_error ? "error" : "reason"}
|
|
</span>
|
|
<span className="violations-panel-witness-value">{witness.reason}</span>
|
|
</div>
|
|
) : null}
|
|
{witness.step ? (
|
|
<div className="violations-panel-witness-line">
|
|
<span className="violations-panel-witness-key">caused at</span>
|
|
{onJumpToStep ? (
|
|
<button
|
|
type="button"
|
|
className="violations-panel-witness-step"
|
|
onClick={() => onJumpToStep(witness.step as number)}
|
|
>
|
|
step {witness.step}
|
|
</button>
|
|
) : (
|
|
<span className="violations-panel-witness-value">step {witness.step}</span>
|
|
)}
|
|
</div>
|
|
) : null}
|
|
{evidence.length > 0 ? (
|
|
<details className="violations-panel-residual" open={open}>
|
|
<summary>witness</summary>
|
|
<dl className="violations-panel-witness-evidence">
|
|
{evidence.map(([name, value]) => (
|
|
<div key={name} className="violations-panel-witness-line">
|
|
<dt className="violations-panel-witness-key">{name}</dt>
|
|
<dd className="violations-panel-witness-value">{formatValue(value)}</dd>
|
|
</div>
|
|
))}
|
|
</dl>
|
|
</details>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export default function ViolationsPanel({
|
|
propertyNames,
|
|
violations,
|
|
residuals,
|
|
witnesses,
|
|
onJumpToFirstViolation,
|
|
hasFirstViolation,
|
|
onJumpToStep,
|
|
violationsOnly = false,
|
|
}: ViolationsPanelProps) {
|
|
const violationSet = useMemo(() => new Set(violations), [violations]);
|
|
|
|
const rows = useMemo(() => {
|
|
const sorted = [...propertyNames].sort((a, b) => a.localeCompare(b));
|
|
const all = sorted.map((name) => ({
|
|
name,
|
|
status: statusFor(name, violationSet, residuals),
|
|
}));
|
|
const filtered = violationsOnly ? all.filter((row) => row.status === "violated") : all;
|
|
return filtered.sort((a, b) => {
|
|
const groupDelta = STATUS_ORDER[a.status] - STATUS_ORDER[b.status];
|
|
if (groupDelta !== 0) {
|
|
return groupDelta;
|
|
}
|
|
return a.name.localeCompare(b.name);
|
|
});
|
|
}, [propertyNames, violationSet, residuals, violationsOnly]);
|
|
|
|
if (violationsOnly && rows.length === 0) {
|
|
return <div className="status-block">no violations</div>;
|
|
}
|
|
|
|
return (
|
|
<section className="violations-panel">
|
|
{violationsOnly ? null : (
|
|
<header className="violations-panel-header">
|
|
<h2 className="violations-panel-title">properties</h2>
|
|
<button
|
|
type="button"
|
|
className="violations-panel-jump"
|
|
onClick={onJumpToFirstViolation}
|
|
disabled={!hasFirstViolation}
|
|
>
|
|
jump to first violation
|
|
</button>
|
|
</header>
|
|
)}
|
|
<ul className="violations-panel-list">
|
|
{rows.map(({ name, status }) => {
|
|
const residual = residuals?.[name];
|
|
const witness = status === "violated" ? witnesses?.[name] : undefined;
|
|
return (
|
|
<li key={name} className="violations-panel-row" data-status={status}>
|
|
<div className="violations-panel-row-head">
|
|
<span
|
|
className="violations-panel-badge"
|
|
data-status={status}
|
|
aria-label={`status ${status}`}
|
|
>
|
|
{status}
|
|
</span>
|
|
<span className="violations-panel-name">{name}</span>
|
|
</div>
|
|
{witness ? (
|
|
<WitnessView witness={witness} onJumpToStep={onJumpToStep} open={violationsOnly} />
|
|
) : null}
|
|
{residual ? (
|
|
<details className="violations-panel-residual">
|
|
<summary>residual</summary>
|
|
<ResidualNodeView node={residual} />
|
|
</details>
|
|
) : null}
|
|
</li>
|
|
);
|
|
})}
|
|
</ul>
|
|
</section>
|
|
);
|
|
}
|