5 Commits

Include renames

Author	SHA1	Message	Date
pj	4caafafb1d	Merge branch 'ci-hygiene-and-fmt' into trial-merge	2026-08-15 20:49:20 +05:30
pj	3865c6515d	ci: move every action off the node20 runtime ... checkout v4->v7, setup-go v5->v7, setup-node v4->v7, setup-java v4->v5, upload-artifact v4->v7, cache v4->v6, upload-pages-artifact v3->v5, deploy-pages v4->v5, setup-chrome v1->v2, setup-android v3->v4, goreleaser-action v6->v7. setup-bun and android-emulator-runner are already node24; buf-setup-action stays on its deliberate SHA pin. setup-chrome v2 resolves stable from Chrome for Testing rather than the official installer, so the ci.yml comment about the action's default no longer held.	2026-08-15 20:41:39 +05:30
pj	3713b8cfb8	ci(folio): drop the stale frontboard note from the ios job	2026-08-15 18:52:59 +05:30
pj	11f72a722a	follow-ups from the pr #73 review (#77) ... * ci(folio): run gradle on jdk 21 for the metro plugin the metro gradle plugin folio builds with publishes org.gradle.jvm.version 21 and java 21 class files, so every leg failed at the folio build on a 17 runtime. local builds pass on jdk 25, which is why only ci saw it. * fix(build): clean pkg/spec/dist, not the dead spec-api path * chore: point stale spec-api comments at pkg/spec * fix(spec): publish src so an installed package carries the runtime entries * fix(testrun): alias the installed spec package so one module graph loads * fix(spec): export Direction, ScrollAction and LongPressAction from the entry * docs(spec): cut the package readme to a description and doc links * docs: say how the cli and spec package versions relate * fix(verifier): report whether the last action was confirmed applied Both hosts get applied: true when the runner saw the dispatch succeed and applied: null when it could not, so an unconfirmed action stops arriving at the spec as no action at all. * fix(runner): an apply error leaves the action's fate unknown, not undone A deadline that fires after the tap was dispatched leaves the effect committed. Reporting nil made the spec see an effect with no action to cause it, which is how the counting property convicts a healthy app. * fix(release): stage the sidecar jar at the renamed embed path * test(replay-ui): trace fixtures for the vacuity counts one real green run, one run that rendered nothing, one that judges every property at least once. * ci(replay-ui): count the steps each property judged the exit code says no property returned false; it does not say any property was ever evaluated. this reads the trace and reports judged vs declined per property, and fails when the step page never rendered. * test(replay-ui): cover the summary script from make test * ci(replay-ui): summarise through the vacuity script * docs(ci): explain the replay-ui judged/declined counts * fix(verifier): encode element-valued extractors into the trace An ax element exports with its find/findAll host functions attached, and json.Marshal refuses the whole value over them: json: unsupported type: func(goja.FunctionCall) goja.Value. The encoding failed, curr stayed nil, and the goja hosts (ios, android) recorded null for every element-valued extractor in both the per-step diff and the violation witness. Apply the web host's sanitize rule before marshaling, so one rule encodes an element on both hosts. * test(verifier): pin element encoding to one rule on both hosts * test(runner): assert an element reaches trace.jsonl and its witness * feat(spec): give state.lastAction an applied field Three states, not two: no action is a null lastAction, applied: true is an action the runner confirmed, applied: null is one it dispatched and never learned the fate of. * fix(folio): do not attribute an effect to an unconfirmed action submitChangesBalanceByTypedAmount and createdAccountHasNonZeroBalance both convict by pinning an effect on the last action, so both decline unless the runner saw it applied. The fixtures now say which fate they mean. * test(folio): an unconfirmed submit belongs in the window The count is an upper bound on the submits a window holds, so the tap that may have landed counts and committedTransactionsExceedSubmits has nothing to convict on. * test(runner): a tap that lands under a failed apply is not a double submit Drives the real folio counting predicates through the runner against a device that commits the tap and then times out. The double-submit case is the control: without it a green proves only that the property never fired. * test(verifier): pin the three lastAction states on both hosts The web page is handed the same applied field the goja object exposes, so a property cannot read one thing on native and another on web. * docs(spec-language): document the three lastAction states	2026-08-15 15:51:33 +05:30
pj	b02e86b2e3	ci: dispatch workflows for folio and the replay ui (#73) ... * feat(runner): stop the step loop at the first violation on request * feat(testrun): report violations as a typed error under exit-on-violation * feat(cli): add --exit-on-violation and exit 2 when it fires * docs(cli): document --exit-on-violation, --max-steps, and exit codes * fix(web): enumerate and query across shadow roots in both producers * test(chrome): compare both producers on a shadow-dom parity page * test(browser): drive a canvas-under-shadow-root fixture end to end * fix(web): select the focused field inside a shadow root before typing * fix(web): report the pathname as the screen when there is no hash route * fix(web): settle on dom quiescence instead of returning at body ready * feat(replay-ui): add data-testid hooks the dogfood spec drives * feat(replay-ui): add the dogfood spec sanderling runs against the replay ui * fix(replay-ui): scope the screenshot property to the named state panel * chore(make): add per-platform sanderling build targets * ci: add dispatch workflows for folio and the replay ui * docs: describe the dispatch workflows and how to read a failure * ci(folio): give the ios leg its jdk, android sdk, just, and a clean app start * refactor(web): use max for the settle budget * ci: pin calibrated seeds, skip the flaky ios reinstall, bound every job * ci: authenticate and pin the buf setup step the anonymous release download hit the shared runner ip rate limit and failed the job with 'socket hang up' after three retries. * docs: record that canvas apps need a dom proxy to be text-fuzzable * fix(ios): bound lifecycle rpcs and claim the target device a launch the simulator rejects sent the xctest session into a recovery chain that answered minutes late or never, and the rpc had no deadline, so the run hung with no trace and no error. also take a per-udid flock: a second run's reinstall lands under the first's live automation session and wedges it. * docs(ci): correct the ios hang wording and note the device lock * refactor(verifier): derive the lastAction shape from one field list both hosts must show a spec the same lastAction. one ordered list now feeds the goja object and the json the web host installs, so they cannot drift. * fix(web): install lastAction in the page before extractors read it state.lastAction was hardcoded null on web, so every property reading it was silently vacuous: a correct property passed without ever firing. * fix(web): carry element identity on actions and fix findAll on paths an action's target was coordinates only, so a property matching on which element was acted upon could never fire. ax.findAll([a,b]) also returned nothing on web. * fix(chrome): wait out a route transition before sampling facts the tree stays byte-identical and quiet across a cross-fade, so both the quiet timer and the unchanged-tree escape called it settled mid-flight and extractors read two screens at once. * fix: bound the pre-run app launch launch happens before the runner starts, so --duration never covered it and a wedged driver hung with no trace and no error. * fix(folio): read balances from merged cards and treat unreadable as unknown compose for web merges the whole accountcard subtree, so the balance child never exists there and every card parsed as 0. the property then compared 0 to 0 and fired on any submit, which is a false positive generator. unknown is now null and null is vacuously true. * test(folio): cover merged-card parsing and unknown balances * ci(folio): make web an expect-the-bug leg the web runtime can observe the double submit now, so the health gate understates it. seed 1 finds it at step 109, 3 runs out of 3. * docs(ci): explain why a submit tap landing on home is the bug * fix(ios): read a StaticText's label as its text AXValue was the only source for text, but a StaticText carries its string in AXLabel, so nothing on screen had .text on ios: a spec reading it saw everything on android and nothing here. * docs(ci): correct the calibrated step ranges * fix(folio): stop convicting on arithmetic float64 cannot hold past 2^53 cents the gap between representable values is 128, so a real 1600-cent move reads back as something else and the equality is false for a healthy submit as readily as a double one. also match parseCents: a sign or an oversized amount is rejected, not read as an amount. * test(folio): pin the safe-integer guard and its boundary * docs: stop teaching the zero-default that caused a false alarm * docs: write down the silent-vacuity failure modes * feat(folio): tag the home total and the card transaction count the total was the only untagged node on the screen, so the spec had to sum cards and a clipped card broke the sum. * fix(folio): read the app's own total and refuse contaminated windows summing cards went null when one was clipped, and the null poisoned the carrier for the rest of the run. the balance window also spanned every transaction since the last home visit, so the property convicted on deltas it could not attribute: the old web witness was 3.16x the typed amount, not 2x. * test(folio): pin the window rules and the count invariant * fix(folio): never read a frame that shows two screens android dumps a cross-fade with both screens in the tree. the route said add-transaction while an unscoped find said home, so the oracle took a half-rendered total as fresh and convicted on a tap that committed nothing. one function now decides the route and returns null when the frame is ambiguous. * test(folio): cover transition frames, card readings and creation * fix(folio): only disambiguate counts that came from merged text the equal-length digit rule exists because web merges the card and an account named -1 makes '12' ambiguous. a dedicated count node has nothing to disambiguate, so applying it there threw away real evidence. * ci(folio): pin the recalibrated seeds and drop android to a health gate web 3 and ios 7 convict 3 runs out of 3 with an exactly 2x witness. android convicts 2 in 5 because the same seed does not walk the same trajectory there, so it proves the app runs instead. * docs(ci): describe the two properties and why android cannot convict * fix(android): wait out a route cross-fade before snapshotting the dump could hold two screens at once, and the runner refuses to act on such a tree, so a quarter of android steps applied no action and the count varied per run: the same seed never walked the same trajectory. the ios companion and the chrome driver already do this. * ci(folio): let the android leg run far enough to see its conviction * docs: only the repo owner merges * ci(folio): a thrown predicate is not a conviction exit 2 means the run recorded a violation, and a predicate that throws is recorded as one too. so was newAccountBalanceIsZero, an unrelated property in the same spec. the gate read the exit code and went green with detection dead. * ci: install idb-companion from its tap and stop interpolating inputs idb-companion is not in homebrew-core, so the ios leg died before it built anything. replay-ui expanded dispatch inputs into the shell. * docs: correct the snippets and numbers that drifted from the code * test(sidecar): pin that a slow read counts toward the stability streak * fix(web): read the page's extractors only on steps that count the page advances the spec's carriers when it evaluates, but the runner applied the result only on non-transitional steps. a discarded step moved the window forward anyway, so the next accepted pair bracketed two transactions while counting one submit, and convicted a healthy app. extractor errors now fail the run instead of leaving goja's values in current against v8's in previous. * fix(chrome): anchor the transition deadline when the dom goes quiet it was anchored at script start, so a page that churned past the window reached the check already expired and returned mid cross-fade. the driver now publishes the idle timeout it needs, since the caller's 1s could never spend the 800ms window. * fix(web): fail on a partial extractor override same mixed-producer hazard as the install error: some extractors hold the page's value and the rest hold goja's, and a property comparing across that split fires on a healthy app. * docs: six of seven, the seventh is the stock property * fix(folio): drop a name two cards answer to homeTxnCountsOf keyed on the account name and let the last card win, so two accounts the fuzzer named the same collapsed into one entry. a reading that saw one Travel card and a later one that saw both then subtracted two different accounts' counts, and submitCommitsOneTransactionPerAction convicted a healthy app of double-submitting. it is a gated property in folio-run.sh, so that reads as "found the submit bug" over a card scrolling into view. same rule createdAccountHasNonZeroBalance already applies: a name nothing can attribute is no evidence. counted over every card, since an unreadable twin spoils the identity too. * perf(folio): read each frame once every extractor asked routeOf, and routeOf does five ax.find calls. on web each find walks the document and every shadow root beneath it, so the spec cost 110 tree walks a step; homeCards was parsed four times over. now 5 and once. keyed on the identity of the state object because both hosts build a new one per step and hand that one object to every getter, so it cannot outlive its frame. holding the reference is what keeps that true rather than likely. * fix(web): keep an undefined reading's index through JSON json has no undefined, so an extractor whose getter returned one had its whole index dropped by JSON.stringify. that index then kept goja's dump-derived value while its neighbours held the page's, and a property comparing previous to current across the split fires on a healthy app. folio has nine on(route, tag) extractors, so this was most extractors on most steps. each reading is wrapped in a {value} envelope: the drop now happens inside the entry, and an absent value means the getter returned undefined, which is what the goja host records for the same getter. a json null would instead claim it returned null and x.current === undefined would answer differently on the two hosts. * feat(verifier): report the registered extractor count the web path needs it to check the page sent one reading per extractor. * fix(runner): fail when the page reports fewer readings than extractors the comment here already claimed a partial override was fatal. it was not: the skipped check only catches indices outside the extractor list, so a page reporting values for some extractors and not others left the rest holding goja's reading of the dump with nothing said. * test(browser): drive an undefined reading through the whole web path four layers carry it: the page's envelope, the driver's unwrap, the runner's count check and the verifier's decode. each has a unit test and only a run proves they compose. goes red both ways, decoding an absent value as null and dropping the envelope. * fix(web): offer the aria roles a user activates only role=button was in the tappable set, so link, checkbox, radio, switch, tab, option, the menuitems and treeitem were invisible to the enumeration however plain the control looked. the replay ui builds its step rows as <li role="option">, and the spec dogfooding it had to hand-write an action to reach them because no default verb could see a single row. both producers build the set from the same role list, since the parity test compares them element by element. * test(browser): tap a role-based control end to end every control on the page is an <li role="option">, the shape the replay ui gives its step rows, and the spec carries no action of its own: the property firing is the evidence the default enumeration offered a tap on one. * fix(web): read aria-disabled as disabled the enabled fact came off the disabled property, which only real form controls have. it reads undefined on the role-based controls the tappable set now covers, so every one of them looked enabled however plainly it was marked otherwise, and the fuzzer would spend actions on inert ones. both producers answer the same two ways, and the parity fixture carries a disabled row so the comparison covers it: reverting one side alone names the element and the fact. * docs(replay-ui): the enumeration reaches step rows now the comment said role="option" is not in the tappable selector set, which stopped being true a few commits ago. selectAStep stays, for the reason the tab weight below it stays: one row among the page's clickable elements is a thin chance, and both step-facing properties go vacuous on a run that never selects one. * test(runner): bound the last-action test by steps, not wall clock 100ms of wall clock against an assertion that two steps ran fatals under load with "the web path never installed it", which reads as a regression. every sibling test in the package uses a long duration and MaxSteps. * ci: run the kotlin tests in make test RouteTransitionTest and the stability poll cover the android settle and nothing in ci ran them. :sidecar:test needs no android sdk, checked by running it with ANDROID_HOME pointed at nothing. * fix(sidecar): measure the stability streak as observed quiet parameterising pollUntilStable also moved the clock to the start of the read that opened a run of identical snapshots, so a read's own duration counted as quiet. the pre-existing caller polls a real uiautomator dump: at 400ms a read, 750ms of required quiet became 250ms of observed quiet and the poll settled in two reads instead of four. the parameters stay, the semantics go back. * test(sidecar): pin the transition cap by driving it it asserted 1500 >= 700 + 300, two constants, which can only fail if someone edits a constant. it now drives awaitSettledTree against a fade that lands after 700ms and asserts it hands back the settled tree before the cap. cut the cap to 1000 and it goes red. * ci: pin buf-setup-action to a commit it takes a token now, so a floating tag is a token handed to whatever that tag moves to. note v1 there is a branch, not a tag, so the ref lookup that resolves it is matching-refs/heads/v1. * ci: declare least-privilege permissions none of the three declared any, so each got the repository default. release.yml and docs.yml already do this. all three only check out, build, test and upload artifacts. * ci: fail fast when a server never comes up the readiness loops fell through silently after 30 tries, so a server that never started surfaced as an opaque driver failure minutes later. each now says what did not answer and on which port. * ci(folio): a missing trace is not a verdict with no trace the android gate ran its grep against ./trace.jsonl and reported "never reached AddTransactionScreen, so it never got past login", which is not what happened. the web and ios branches had the same misdiagnosis on exit 0. same class, one line up: the classifier's own failure was swallowed, so with the evidence reader dead the gate printed a healthy run and exited 0. * ci(replay-ui): skip a run directory with no trace the summarise step is if: always(), and under github's bash -eo pipefail an unmatched glob stays literal, the redirect fails, pipefail carries it into the assignment and -e kills the step. so a failed fuzz run went red twice, once for the real reason.	2026-08-15 13:01:27 +05:30