feat(driver): add env param to Launch interface and all implementations

This commit is contained in:
pj committed 2026-04-23 17:33:19 +07:00
1 parent 3a6979a9db
commit f446439e33
6 files changed
+7 -6

No files matched your search

+1 -1
View File
@@ -77,7 +77,7 @@ func New() *Driver {
return d
}
func (d *Driver) Launch(ctx context.Context, bundleID string, clearState bool) error {
func (d *Driver) Launch(ctx context.Context, bundleID string, clearState bool, _ map[string]string) error {
if clearState {
if err := chromedp.Run(d.tabCtx, network.ClearBrowserCookies()); err != nil {
return fmt.Errorf("clear cookies: %w", err)
+1 -1
View File
@@ -10,7 +10,7 @@ import (
// lives under driver/sidecar; the web implementation under driver/chrome;
// tests use driver/mock.
type DeviceDriver interface {
Launch(ctx context.Context, bundleID string, clearState bool) error
Launch(ctx context.Context, bundleID string, clearState bool, env map[string]string) error
Terminate(ctx context.Context) error
Tap(ctx context.Context, x, y int) error
+1 -1
View File
@@ -88,7 +88,7 @@ func (d *Driver) failure(kind ActionKind) error {
return d.Failures[kind]
}
func (d *Driver) Launch(_ context.Context, bundleID string, clearState bool) error {
func (d *Driver) Launch(_ context.Context, bundleID string, clearState bool, _ map[string]string) error {
if err := d.failure(ActionLaunch); err != nil {
return err
}
+1 -1
View File
@@ -29,7 +29,7 @@ func TestRecordsAllActionsInOrder(t *testing.T) {
mock := New()
ctx := context.Background()
if err := mock.Launch(ctx, "com.example", true); err != nil {
if err := mock.Launch(ctx, "com.example", true, nil); err != nil {
t.Fatal(err)
}
if err := mock.Tap(ctx, 100, 200); err != nil {
+2 -1
View File
@@ -48,10 +48,11 @@ func (c *Client) WaitForHealth(ctx context.Context, pollInterval time.Duration)
}
}
func (c *Client) Launch(ctx context.Context, bundleID string, clearState bool) error {
func (c *Client) Launch(ctx context.Context, bundleID string, clearState bool, env map[string]string) error {
_, err := c.stub.Launch(ctx, &driverpb.LaunchRequest{
BundleId: bundleID,
ClearState: clearState,
Env: env,
})
return err
}
+1 -1
View File
@@ -191,7 +191,7 @@ func TestClient_LaunchAndTerminate(t *testing.T) {
client, _ := Dial(state.address)
defer client.Close()
if err := client.Launch(context.Background(), "com.example", true); err != nil {
if err := client.Launch(context.Background(), "com.example", true, nil); err != nil {
t.Fatal(err)
}
if state.fake.launchedBundleID != "com.example" || !state.fake.clearState {