fix(selectors): resolve text to the innermost match and scan the root in both forms

an element's text is its whole subtree's text on web and on ios, so every ancestor of a matching element matched too, up to the root. a match a descendant also makes is now dropped, in internal/hierarchy, in the chrome xpath translation and in the page-side web runtime, so all three resolvers name the same element. a raw attribute now matches on a substring (exact for true/false) the way the docs describe, and tree-level FindBySelector considers the root, so ax.find("id:page") and ax.find({id: "page"}) agree.
This commit is contained in:
pj committed 2026-08-16 17:43:10 +05:30
1 parent a245194120
commit ca667b1b77
9 files changed
+526 -49

No files matched your search

+24 -2
View File
@@ -39,7 +39,14 @@ func TranslateStringSelector(selector string) (string, bool, error) {
case "tag":
return cssEscape(value), false, nil
case "text":
return `//*[normalize-space(text())=` + xpathStringLiteral(value) + `]`, true, nil
// Substring of the element's whole text, the way internal/hierarchy
// reads the same selector: an element reading "Sent ✓" answers to
// text:Sent on every platform, and one React wrote as `{count} unsent`
// answers to text:unsent though its text arrives as two text nodes.
// normalize-space(text()) would read only the first of them. The
// not() clause is what keeps the badge's ancestors, up to <html>, from
// answering for it.
return `//*[` + innermostTextPredicate(value) + `]`, true, nil
case "desc":
// Mirrors the native rule: the label itself, or the label at the head of
// an iOS merged label ("account_card:7, Tim, $100").
@@ -63,7 +70,11 @@ func TranslateStringSelector(selector string) (string, bool, error) {
if !attrNamePattern.MatchString(kind) {
return "", false, fmt.Errorf("unsafe selector prefix %q", kind)
}
return `[` + kind + `="` + cssEscape(value) + `"]`, false, nil
operator := `*=`
if value == "true" || value == "false" {
operator = `=`
}
return `[` + kind + operator + `"` + cssEscape(value) + `"]`, false, nil
}
}
@@ -95,6 +106,17 @@ func cssEscape(value string) string {
return builder.String()
}
// innermostTextPredicate matches an element whose text contains value and whose
// descendants do not, which is the innermost match internal/hierarchy resolves
// the same selector to. The same predicate appears in
// pkg/spec/src/web-runtime.ts.
func innermostTextPredicate(value string) string {
contains := `contains(normalize-space(.), ` + xpathStringLiteral(
value,
) + `)`
return contains + ` and not(.//*[` + contains + `])`
}
// xpathStringLiteral wraps the value in a valid XPath 1.0 string literal.
// XPath 1.0 has no escape syntax, so a value containing both ' and " must be
// composed via concat(). The output already includes the surrounding quotes