fix(doctor): raise per-check timeout to 15s for chromium launch

5s could time out the headless chromium check on cold CI. Most checks
finish in milliseconds, so a longer ceiling doesn't slow real
failures.
This commit is contained in:
pj committed 2026-05-03 11:08:39 +07:00
1 parent 07ae3f265d
commit b9ac133345
1 file changed
+7 -1
+7 -1
View File
@@ -128,10 +128,16 @@ func parseDoctorArgs(args []string, stderr io.Writer) (doctorOptions, error) {
}
}
// doctorCheckTimeout bounds a single host-readiness check. Most checks (exec
// lookups, file stats, java -version) finish in milliseconds, but
// checkChromiumLaunch boots a real browser and can exceed 5s on a cold CI
// host - 15s leaves headroom without making real failures feel hung.
const doctorCheckTimeout = 15 * time.Second
func runDoctorChecks(ctx context.Context, checks []doctorCheck, stdout io.Writer) error {
failures := 0
for _, check := range checks {
callCtx, cancel := context.WithTimeout(ctx, 5*time.Second)
callCtx, cancel := context.WithTimeout(ctx, doctorCheckTimeout)
err := check.Run(callCtx)
cancel()
if err != nil {