pj/sanderling
1
0 Fork 0
mirror of https://github.com/priyanshujain/sanderling.git synced 2026-10-02 19:17:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(spec): pin the unknown-key diagnostic to one text

Browse Source 
The two runtimes each claimed to raise the other's message and nothing
checked it. Both now render the committed text for the committed key.
This commit is contained in:
pj committed 2026-08-13 00:39:29 +05:30
1 parent 269574706d
commit b8bb44cf61
4 files changed
+95 -54
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

pkg/spec/src/web-runtime.ts
+1
View File
@@ -694,6 +694,7 @@ export const __testing__ = {
selectorFromString,
selectorFromObject,
SELECTOR_KEYS,
unknownSelectorKeyMessage,
xpathStringLiteral,
};
pkg/spec/test/fixtures/selector-keys.json
Vendored
+44 -38
View File
@@ -1,38 +1,44 @@
[
"accessibilityIdentifier",
"accessibilityLabel",
"accessibilityText",
"aria-label",
"ariaLabel",
"bounds",
"checked",
"class",
"className",
"clickable",
"content-desc",
"contentDescription",
"data-testid",
"desc",
"descPrefix",
"editable",
"elementType",
"enabled",
"focused",
"hintText",
"id",
"idPrefix",
"identifier",
"label",
"package",
"placeholder",
"placeholderValue",
"resource-id",
"scrollable",
"selected",
"tag",
"testID",
"testTag",
"text",
"title",
"value"
]
{
"keys": [
"accessibilityIdentifier",
"accessibilityLabel",
"accessibilityText",
"aria-label",
"ariaLabel",
"bounds",
"checked",
"class",
"className",
"clickable",
"content-desc",
"contentDescription",
"data-testid",
"desc",
"descPrefix",
"editable",
"elementType",
"enabled",
"focused",
"hintText",
"id",
"idPrefix",
"identifier",
"label",
"package",
"placeholder",
"placeholderValue",
"resource-id",
"scrollable",
"selected",
"tag",
"testID",
"testTag",
"text",
"title",
"value"
],
"unknownKeyExample": [
"descripton"
],
"unknownKeyMessage": "selector key \"descripton\" cannot match: no element carries that attribute, and it is not one of the accepted keys: accessibilityIdentifier, accessibilityLabel, accessibilityText, aria-label, ariaLabel, bounds, checked, class, className, clickable, content-desc, contentDescription, data-testid, desc, descPrefix, editable, elementType, enabled, focused, hintText, id, idPrefix, identifier, label, package, placeholder, placeholderValue, resource-id, scrollable, selected, tag, testID, testTag, text, title, value"
}
pkg/spec/test/selector-keys.test.ts
+13 -3
View File
@@ -5,10 +5,14 @@ import { test } from "node:test";
import { __testing__ } from "../src/web-runtime.ts";
const { SELECTOR_KEYS } = __testing__;
const { SELECTOR_KEYS, unknownSelectorKeyMessage } = __testing__;
const goldenPath = fileURLToPath(new URL("./fixtures/selector-keys.json", import.meta.url));
const golden: string[] = JSON.parse(readFileSync(goldenPath, "utf8"));
const golden: {
keys: string[];
unknownKeyExample: string[];
unknownKeyMessage: string;
} = JSON.parse(readFileSync(goldenPath, "utf8"));
// Both runtimes reject an object-selector key they do not know, so the two key
// lists have to be one list. Were they to drift, a spec would be accepted by
@@ -17,5 +21,11 @@ const golden: string[] = JSON.parse(readFileSync(goldenPath, "utf8"));
// internal/hierarchy/selector_keys_test.go asserts the SAME file from the
// native side.
test("the web key list is the cross-runtime list", () => {
assert.deepEqual([...SELECTOR_KEYS], golden);
assert.deepEqual([...SELECTOR_KEYS], golden.keys);
});
// An author who hits this on Android and again on web must read one sentence,
// not two dialects of it.
test("the web diagnostic is the cross-runtime text", () => {
assert.equal(unknownSelectorKeyMessage(golden.unknownKeyExample), golden.unknownKeyMessage);
});