fix(testrun): an ios run records the simulator it executed on

Device was read from --device, which only an android run sets, so every
ios meta.json left the field empty and the trace could not say what
hardware produced it.
This commit is contained in:
pj committed 2026-08-18 16:38:00 +05:30
1 parent 6cac99cc32
commit b278fc869d
2 files changed
+40 -1

No files matched your search

+30
View File
@@ -282,6 +282,36 @@ func TestBuildRunMeta_RecordsLabelSourceForASeededRun(t *testing.T) {
}
}
// An ios run names its simulator with --ios-device, so reading the android
// --device flag left every ios trace unable to say what it executed on.
func TestBuildRunMeta_NamesTheIosSimulatorItRanOn(t *testing.T) {
options := Options{
Platform: "ios",
Generator: "seeded",
Duration: time.Minute,
IosDevice: "iPhone 17 Pro",
}
meta := buildRunMeta(options, "deadbeef", 1, "farm-01", verifier.LLMConfig{}, false)
if meta.Device != "iPhone 17 Pro" {
t.Errorf("device: got %q, want the ios simulator the run named", meta.Device)
}
}
func TestBuildRunMeta_NamesTheAndroidDeviceItRanOn(t *testing.T) {
options := Options{
Platform: "android",
Generator: "seeded",
Duration: time.Minute,
Device: "emulator-5554",
}
meta := buildRunMeta(options, "deadbeef", 1, "farm-01", verifier.LLMConfig{}, false)
if meta.Device != "emulator-5554" {
t.Errorf("device: got %q, want the android device the run named", meta.Device)
}
}
func TestBuildRunMeta_OmitsModelWhenSpecDeclaresNoLLMGenerator(t *testing.T) {
options := Options{Platform: "android", Generator: "llm", Duration: time.Minute}
meta := buildRunMeta(options, "deadbeef", 1, "farm-01", verifier.LLMConfig{}, false)