From b131c69e7bd9643a8ea840c98a5da28f0a3344c3 Mon Sep 17 00:00:00 2001
From: PJ <ipriyanshujain@gmail.com>
Date: Sun, 16 Aug 2026 01:29:58 +0530
Subject: [PATCH] test(browser): cover console.error with an error object

Claude-Session: https://claude.ai/code/session_01ShuAy8q8ZfPi8KHxwc8JpQ
---
 test/browser/console_levels_test.go           | 38 +++++++++++++------
 .../testdata/console-levels/index.html        |  1 +
 2 files changed, 27 insertions(+), 12 deletions(-)

diff --git a/test/browser/console_levels_test.go b/test/browser/console_levels_test.go
index ac3d625..a1b81de 100644
--- a/test/browser/console_levels_test.go
+++ b/test/browser/console_levels_test.go
@@ -31,14 +31,22 @@ func TestBrowserConsoleErrorReachesTheSpec(t *testing.T) {
 	if err != nil {
 		t.Fatalf("recent logs: %v", err)
 	}
-	if len(entries) != 1 {
-		t.Fatalf("the runner's error-level fetch returned %d entries, want the page's one console.error: %+v", len(entries), entries)
+	if len(entries) != 2 {
+		t.Fatalf("the runner's error-level fetch returned %d entries, want the page's two console.error calls: %+v", len(entries), entries)
 	}
-	if entries[0].Level != "E" {
-		t.Errorf("console.error arrived as level %q, want %q", entries[0].Level, "E")
+	for _, entry := range entries {
+		if entry.Level != "E" {
+			t.Errorf("console.error %q arrived as level %q, want %q", entry.Message, entry.Level, "E")
+		}
 	}
-	if !strings.Contains(entries[0].Message, "boom from the page") {
-		t.Errorf("console.error arrived as %q, want the page's message", entries[0].Message)
+	// console.error(err) is the ordinary way a page reports a failure, and the
+	// argument is then an object rather than a string. An entry that arrives
+	// with the right level and no message names nothing a reader can act on.
+	if !messageSeen(entries, "boom from the page") {
+		t.Errorf("the page's console.error string never arrived: %+v", entries)
+	}
+	if !messageSeen(entries, "object arg detail") {
+		t.Errorf("console.error(new Error(...)) arrived with no message: %+v", entries)
 	}
 
 	dump, err := driverInstance.Hierarchy(ctx)
@@ -86,8 +94,8 @@ func TestBrowserConsoleLevelsMapToTheLogcatScale(t *testing.T) {
 	if err != nil {
 		t.Fatalf("recent logs: %v", err)
 	}
-	if len(entries) != 6 {
-		t.Fatalf("the page made 6 console calls, the driver kept %d: %+v", len(entries), entries)
+	if len(entries) != 7 {
+		t.Fatalf("the page made 7 console calls, the driver kept %d: %+v", len(entries), entries)
 	}
 
 	wantLevels := map[string]string{
@@ -122,15 +130,15 @@ func TestBrowserConsoleLevelsMapToTheLogcatScale(t *testing.T) {
 	if err != nil {
 		t.Fatalf("recent logs: %v", err)
 	}
-	if len(errorsOnly) != 1 {
-		t.Fatalf("the error-level fetch kept %d of the 6 entries, want only the console.error: %+v", len(errorsOnly), errorsOnly)
+	if len(errorsOnly) != 2 {
+		t.Fatalf("the error-level fetch kept %d of the 7 entries, want only the console.error calls: %+v", len(errorsOnly), errorsOnly)
 	}
 	warningsUp, err := driverInstance.RecentLogs(ctx, since, "W")
 	if err != nil {
 		t.Fatalf("recent logs: %v", err)
 	}
-	if len(warningsUp) != 2 {
-		t.Fatalf("the warning-level fetch kept %d entries, want the console.error and the console.warn: %+v", len(warningsUp), warningsUp)
+	if len(warningsUp) != 3 {
+		t.Fatalf("the warning-level fetch kept %d entries, want the console.error calls and the console.warn: %+v", len(warningsUp), warningsUp)
 	}
 }
 
@@ -160,6 +168,12 @@ func launchConsoleFixture(t *testing.T) (context.Context, *chrome.Driver, time.T
 	return ctx, driverInstance, since
 }
 
+func messageSeen(entries []driver.LogEntry, want string) bool {
+	return slices.ContainsFunc(entries, func(entry driver.LogEntry) bool {
+		return strings.Contains(entry.Message, want)
+	})
+}
+
 func asVerifierLogs(entries []driver.LogEntry) []verifier.LogEntry {
 	out := make([]verifier.LogEntry, 0, len(entries))
 	for _, entry := range entries {
diff --git a/test/browser/testdata/console-levels/index.html b/test/browser/testdata/console-levels/index.html
index 56da280..1683068 100644
--- a/test/browser/testdata/console-levels/index.html
+++ b/test/browser/testdata/console-levels/index.html
@@ -9,6 +9,7 @@
     <div id="count">0</div>
     <script>
       console.error("boom from the page");
+      console.error(new Error("object arg detail"));
       console.warn("a warning");
       console.log("a plain log");
       console.debug("a debug line");