From a74fa46221d316de08477fcd927fd41e93894068 Mon Sep 17 00:00:00 2001 From: PJ Date: Sat, 6 Jun 2026 12:47:10 +0530 Subject: [PATCH] test(sidecarassets): assert reuse via sentinel bytes not mtime --- internal/sidecarassets/embed_withsidecar_test.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/internal/sidecarassets/embed_withsidecar_test.go b/internal/sidecarassets/embed_withsidecar_test.go index cd82946..3ae7400 100644 --- a/internal/sidecarassets/embed_withsidecar_test.go +++ b/internal/sidecarassets/embed_withsidecar_test.go @@ -3,6 +3,7 @@ package sidecarassets import ( + "bytes" "crypto/sha256" "encoding/hex" "os" @@ -54,21 +55,21 @@ func TestExtract_ReusesIdenticalFile(t *testing.T) { if err != nil { t.Fatal(err) } - originalStat, err := os.Stat(path) - if err != nil { + sentinel := []byte("SENTINEL-do-not-rewrite") + if err := os.WriteFile(path, sentinel, 0o644); err != nil { t.Fatal(err) } - originalModTime := originalStat.ModTime() if _, err := Extract(directory); err != nil { t.Fatal(err) } - secondStat, err := os.Stat(path) + + after, err := os.ReadFile(path) if err != nil { t.Fatal(err) } - if !secondStat.ModTime().Equal(originalModTime) { - t.Errorf("second extract should not have rewritten the file") + if !bytes.Equal(after, sentinel) { + t.Errorf("second extract rewrote the existing JAR; reuse branch corrupted on-disk file") } }