mirror of
https://github.com/priyanshujain/sanderling.git
synced 2026-10-02 19:17:10 +00:00
fix(verifier): refresh predicate errors per step
EvaluateProperties short-circuits once an Always-property latches to violated, so the underlying goja predicate stops being called and formula.err keeps whatever it threw at step 1. The runner logs PredicateError every step a property is violated, which made every subsequent log line repeat the step-1 throw. That looks like the spec runtime is seeing stale state, but it is just stale error reporting. EvaluateProperties now invokes every registered predicate once per step purely to refresh formula.err. Verdicts are unaffected. The thunk itself stops latching so the new value wins on whichever path runs first.
This commit is contained in:
1 parent
a2b4b4290b
commit
9abd0511bd
2 files changed
+25
-6
No files matched your search
@@ -14,9 +14,10 @@ type extractorState struct {
|
||||
|
||||
type formulaState struct {
|
||||
predicate goja.Callable
|
||||
// err latches the first goja error returned by predicate. The thunk
|
||||
// returns false on error so the LTL evaluator marks the property
|
||||
// violated; PredicateError surfaces the underlying cause.
|
||||
// err holds the goja error from this thunk's most recent invocation, or
|
||||
// nil if the latest call succeeded. The thunk returns false on error so
|
||||
// the LTL evaluator marks the property violated; PredicateError surfaces
|
||||
// the underlying cause for the current step.
|
||||
err error
|
||||
}
|
||||
|
||||
|
||||
@@ -254,6 +254,7 @@ func (v *Verifier) EvaluateProperties() map[string]ltl.Verdict {
|
||||
for name, evaluator := range v.evaluators {
|
||||
verdicts[name] = evaluator.ObserveAt(stepTime)
|
||||
}
|
||||
v.refreshPredicateErrors()
|
||||
return verdicts
|
||||
}
|
||||
|
||||
@@ -302,15 +303,32 @@ func (v *Verifier) formulaThunk(index int) func() bool {
|
||||
formula := v.formulas[index]
|
||||
result, err := formula.predicate(goja.Undefined())
|
||||
if err != nil {
|
||||
if formula.err == nil {
|
||||
formula.err = err
|
||||
}
|
||||
formula.err = err
|
||||
return false
|
||||
}
|
||||
formula.err = nil
|
||||
return result.ToBoolean()
|
||||
}
|
||||
}
|
||||
|
||||
// refreshPredicateErrors re-invokes every registered predicate so that
|
||||
// formula.err reflects the current step rather than a latched first-step
|
||||
// throw. EvaluateProperties short-circuits once a property has latched to
|
||||
// violated, so without this refresh the runner's per-step "predicate error"
|
||||
// log freezes on whatever the predicate threw at step 1. The refreshed errors
|
||||
// have no effect on verdicts.
|
||||
func (v *Verifier) refreshPredicateErrors() {
|
||||
for _, formula := range v.formulas {
|
||||
result, err := formula.predicate(goja.Undefined())
|
||||
if err != nil {
|
||||
formula.err = err
|
||||
continue
|
||||
}
|
||||
_ = result
|
||||
formula.err = nil
|
||||
}
|
||||
}
|
||||
|
||||
// PredicateError returns the first goja error raised by any thunk in the
|
||||
// named property's formula tree, or nil if none fired. Callers typically
|
||||
// consult this after EvaluateProperties reports a violation to distinguish
|
||||
|
||||
Reference in new issue
Block a user