test: full test-suite refactor sweep (#61)

* chore(test): start test-suite refactor sweep * test(ltl): pin exact multi-obligation residual AST * test(ltl): table-test finalize Kleene connective combinations * test(ltl): pin reduce over pending inner for bound, Or, Not * test(ltl): marshal bounded Always steps/duration/deadline * test(verifier): cover LTL combinator verdict transitions and within unit panic * test(verifier): table-test DecodeAction kinds and lastAction field exposure * test(verifier): assert WithPlatform(ios) reaches the picker host and key pool * test(verifier): widen weighted-selection assertion to a 5x skew margin * test(verifier): un-skip ax-find round trip with a committed tree fixture * test(runner): pin isWDADrop to sidecar reconnect-failed message origin * test(runner): assert PressKey/Wait trace encoding records kind-specific fields * test(runner): cover RenderSummary unsupported-verbs surfacing branch * test(trace): set Hierarchy in round-trip and lock lossy Tree contract Also add a -race concurrent WriteStep test that asserts N well-formed JSONL lines, catching torn lines if the writer mutex is dropped. * test(trace): round-trip witnesses/changes/metrics/exceptions, pin step-0 witness * test(trace): document ViolationsAreGreppable grep contract and lock-free WriteScreenshot * test(hierarchy): cover invalid-JSON and malformed-bounds parser paths * test(trace): guard writer mutex via WriteStep/Close race on w.file * test(replay): drop unfailable assets and devproxy assertions * test(replay): cache reuses on equal mtime, reparses after append * test(replay): violation marker falls back to detection step when attributed missing * test(replay): corrupt meta/trace dirs return 500 with error body * test(replay): SSE client receives runs.changed after a broadcast * test(replay): Run coalesces creates, ignores write/chmod, closes subs on cancel * fix(sidecar): synchronize health fixture writes and exercise healthError * test(sidecar): cover swipe/longpress/doubletap/erase/presskey/metrics/logs translations * test(sidecar): cover DoubleTapSelector composition and mid-gesture cancel * test(sidecar): assert gRPC error status surfaces from action RPC * fix(chrome): route action methods through runCtx so caller cancellation aborts CDP * fix(chrome): route hierarchy/screenshot/waitidle/metrics through runCtx * refactor(ios): extract pure simctl JSON parsers * refactor(ios): add command-runner seams for EnsureSimulator * test(ios): table-test simctl parsers and EnsureSimulator seams * test(sidecarassets): cover placeholder build path * test(sidecarassets): assert reuse via sentinel bytes not mtime * test(bundler): cover properties-only spec registration * refactor(testrun): extract prepareBundleInputs from Execute * test(testrun): cover prepareBundleInputs aliases and missing-runtime error * test(testrun): table-test resolveRuntimeSibling search edges * test(testrun): exact-output tests for progressHandler line format * fix(cmd): point bundle-check aliases at pkg/spec/src * test(cmd): smoke-test bundle-check resolves spec aliases * test(cmd): table-test hier-check parse and FindAll on fixture * test(cmd): unit-test buildBrowseURL deep-link vs root * test(cmd): drop flaky TestRun_Doctor that launched real Chromium * test(cmd): pin pipeline error to bundle resolution on web platform * test(replay-ui): add bun test script * ci(replay-ui): run bun test via make web-test target * ci(replay-ui): point bun cache key at replay-ui/bun.lock * test(replay-ui): exercise real URL encoding and non-ok throw in getJson * refactor(replay-ui): extract snapshot flatten/getAtPath into lib module * test(replay-ui): pin snapshot flatten/getAtPath path round-trip * refactor(replay-ui): extract action selector/format into lib module * test(replay-ui): pin action selector parse and row formatting * refactor(replay-ui): share one statusFor between panels * refactor(replay-ui): extract run-history derivation into lib module * test(replay-ui): pin shared statusFor precedence and ordering * test(replay-ui): pin run-history derivation alignment * refactor(replay-ui): export clampIndex for testing * refactor(replay-ui): extract keyboard-nav dispatch into pure module * refactor(replay-ui): extract metrics formatters into lib module * test(replay-ui): pin clampIndex step boundaries * test(replay-ui): pin keyboard-nav ownership and key routing * test(replay-ui): pin metrics formatters and path gap handling * refactor(sidecar): expose device-output parsers as internal for testing * test(sidecar): table-test device-output parsers against malformed input * test(sidecar): cover logcat parsing year inference and line skipping * test(sidecar): pin pressKey keycode mapping and unknown-key rejection * test(sidecar): metrics bundleId falls back to launched app and honors override * test(sidecar): loosen deadline upper bound to tolerate slow CI scheduling * test(web-runtime): export selector builders for unit tests * test(web-runtime): guard sanitize cycle, function, and depth limits * test(web-runtime): table-test selector builder quoting and escaping * test(sidecar): collapse scalar-forwarding RPC tests into a table * test(replay-ui): dedup step/summary fixtures into shared module * test(ios): collapse pickSimulator point-tests into a table
2026-10-05 04:27:09 +00:00 · 2026-06-06 13:59:08 +05:30
1 parent 410602d2e1
commit 94d9511312
@@ -0,0 +1,74 @@
+import { describe, it, expect } from "bun:test";
+import {
+  formatActionRow,
+  formatElapsed,
+  parseSelector,
+  tagFromSelector,
+} from "../lib/action-format";
+import { summary } from "./fixtures";
+
+// Bug class: selector parsing mislabels every action row — splitting on the
+// wrong colon, treating a value-with-colon as the kind, or dropping the prefix
+// ellipsis would render the wrong target tag for every step.
+describe("parseSelector", () => {
+  const cases: { input: string; out: ReturnType<typeof parseSelector> }[] = [
+    { input: "id:login", out: { kind: "id", value: "login" } },
+    { input: "text:Sign In", out: { kind: "text", value: "Sign In" } },
+    { input: "textPrefix:Hello", out: { kind: "textPrefix", value: "Hello" } },
+    { input: "id:com.app:id/btn", out: { kind: "id", value: "com.app:id/btn" } },
+    { input: "bogus:x", out: null },
+    { input: ":leading", out: null },
+    { input: "no-colon", out: null },
+  ];
+  for (const { input, out } of cases) {
+    it(`parses ${input}`, () => {
+      expect(parseSelector(input)).toEqual(out);
+    });
+  }
+});
+
+describe("tagFromSelector", () => {
+  it("appends ellipsis only for prefix selectors", () => {
+    expect(tagFromSelector("textPrefix:Hel")).toBe("Hel...");
+    expect(tagFromSelector("text:Hello")).toBe("Hello");
+    expect(tagFromSelector("plain")).toBe("plain");
+  });
+});
+
+describe("formatActionRow", () => {
+  it("observes when no action kind, with and without screen", () => {
+    expect(formatActionRow(summary({}))).toEqual({
+      verb: "Observe",
+      target: "",
+      targetIsTag: false,
+    });
+    expect(formatActionRow(summary({ screen: "Home" }))).toEqual({
+      verb: "Observe",
+      target: "@ Home",
+      targetIsTag: false,
+    });
+  });
+
+  it("treats a selector label as a tag and a coordinate label as literal", () => {
+    expect(
+      formatActionRow(summary({ action_kind: "Tap", action_label: "id:btn" })),
+    ).toEqual({ verb: "Click", target: "btn", targetIsTag: true });
+    expect(
+      formatActionRow(summary({ action_kind: "Tap", action_label: "(10, 20)" })),
+    ).toEqual({ verb: "Click", target: "(10, 20)", targetIsTag: false });
+  });
+
+  it("maps known verbs and falls back to the raw kind", () => {
+    expect(formatActionRow(summary({ action_kind: "InputText", action_label: "hi" })).verb).toBe("Type");
+    expect(formatActionRow(summary({ action_kind: "Swipe" })).verb).toBe("Swipe");
+    expect(formatActionRow(summary({ action_kind: "Custom" })).verb).toBe("Custom");
+  });
+});
+
+describe("formatElapsed", () => {
+  it("formats mm:ss.mmm and clamps negatives to zero", () => {
+    expect(formatElapsed(0)).toBe("00:00.000");
+    expect(formatElapsed(65_432)).toBe("01:05.432");
+    expect(formatElapsed(-50)).toBe("00:00.000");
+  });
+});