mirror of
https://github.com/priyanshujain/sanderling.git
synced 2026-10-02 11:07:10 +00:00
test: full test-suite refactor sweep (#61)
* chore(test): start test-suite refactor sweep * test(ltl): pin exact multi-obligation residual AST * test(ltl): table-test finalize Kleene connective combinations * test(ltl): pin reduce over pending inner for bound, Or, Not * test(ltl): marshal bounded Always steps/duration/deadline * test(verifier): cover LTL combinator verdict transitions and within unit panic * test(verifier): table-test DecodeAction kinds and lastAction field exposure * test(verifier): assert WithPlatform(ios) reaches the picker host and key pool * test(verifier): widen weighted-selection assertion to a 5x skew margin * test(verifier): un-skip ax-find round trip with a committed tree fixture * test(runner): pin isWDADrop to sidecar reconnect-failed message origin * test(runner): assert PressKey/Wait trace encoding records kind-specific fields * test(runner): cover RenderSummary unsupported-verbs surfacing branch * test(trace): set Hierarchy in round-trip and lock lossy Tree contract Also add a -race concurrent WriteStep test that asserts N well-formed JSONL lines, catching torn lines if the writer mutex is dropped. * test(trace): round-trip witnesses/changes/metrics/exceptions, pin step-0 witness * test(trace): document ViolationsAreGreppable grep contract and lock-free WriteScreenshot * test(hierarchy): cover invalid-JSON and malformed-bounds parser paths * test(trace): guard writer mutex via WriteStep/Close race on w.file * test(replay): drop unfailable assets and devproxy assertions * test(replay): cache reuses on equal mtime, reparses after append * test(replay): violation marker falls back to detection step when attributed missing * test(replay): corrupt meta/trace dirs return 500 with error body * test(replay): SSE client receives runs.changed after a broadcast * test(replay): Run coalesces creates, ignores write/chmod, closes subs on cancel * fix(sidecar): synchronize health fixture writes and exercise healthError * test(sidecar): cover swipe/longpress/doubletap/erase/presskey/metrics/logs translations * test(sidecar): cover DoubleTapSelector composition and mid-gesture cancel * test(sidecar): assert gRPC error status surfaces from action RPC * fix(chrome): route action methods through runCtx so caller cancellation aborts CDP * fix(chrome): route hierarchy/screenshot/waitidle/metrics through runCtx * refactor(ios): extract pure simctl JSON parsers * refactor(ios): add command-runner seams for EnsureSimulator * test(ios): table-test simctl parsers and EnsureSimulator seams * test(sidecarassets): cover placeholder build path * test(sidecarassets): assert reuse via sentinel bytes not mtime * test(bundler): cover properties-only spec registration * refactor(testrun): extract prepareBundleInputs from Execute * test(testrun): cover prepareBundleInputs aliases and missing-runtime error * test(testrun): table-test resolveRuntimeSibling search edges * test(testrun): exact-output tests for progressHandler line format * fix(cmd): point bundle-check aliases at pkg/spec/src * test(cmd): smoke-test bundle-check resolves spec aliases * test(cmd): table-test hier-check parse and FindAll on fixture * test(cmd): unit-test buildBrowseURL deep-link vs root * test(cmd): drop flaky TestRun_Doctor that launched real Chromium * test(cmd): pin pipeline error to bundle resolution on web platform * test(replay-ui): add bun test script * ci(replay-ui): run bun test via make web-test target * ci(replay-ui): point bun cache key at replay-ui/bun.lock * test(replay-ui): exercise real URL encoding and non-ok throw in getJson * refactor(replay-ui): extract snapshot flatten/getAtPath into lib module * test(replay-ui): pin snapshot flatten/getAtPath path round-trip * refactor(replay-ui): extract action selector/format into lib module * test(replay-ui): pin action selector parse and row formatting * refactor(replay-ui): share one statusFor between panels * refactor(replay-ui): extract run-history derivation into lib module * test(replay-ui): pin shared statusFor precedence and ordering * test(replay-ui): pin run-history derivation alignment * refactor(replay-ui): export clampIndex for testing * refactor(replay-ui): extract keyboard-nav dispatch into pure module * refactor(replay-ui): extract metrics formatters into lib module * test(replay-ui): pin clampIndex step boundaries * test(replay-ui): pin keyboard-nav ownership and key routing * test(replay-ui): pin metrics formatters and path gap handling * refactor(sidecar): expose device-output parsers as internal for testing * test(sidecar): table-test device-output parsers against malformed input * test(sidecar): cover logcat parsing year inference and line skipping * test(sidecar): pin pressKey keycode mapping and unknown-key rejection * test(sidecar): metrics bundleId falls back to launched app and honors override * test(sidecar): loosen deadline upper bound to tolerate slow CI scheduling * test(web-runtime): export selector builders for unit tests * test(web-runtime): guard sanitize cycle, function, and depth limits * test(web-runtime): table-test selector builder quoting and escaping * test(sidecar): collapse scalar-forwarding RPC tests into a table * test(replay-ui): dedup step/summary fixtures into shared module * test(ios): collapse pickSimulator point-tests into a table
This commit is contained in:
66 files changed
+3419
-606
No files matched your search
+198
-64
@@ -1,85 +1,145 @@
|
||||
package ios
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"errors"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
func TestPickSimulator_ByName(t *testing.T) {
|
||||
available := []simDevice{
|
||||
{UDID: "aaa", Name: "iPad Pro", IsAvailable: true},
|
||||
{UDID: "bbb", Name: "iPhone 15", IsAvailable: true},
|
||||
const simctlJSON = `{
|
||||
"devices": {
|
||||
"com.apple.CoreSimulator.SimRuntime.iOS-17-0": [
|
||||
{"udid": "ipad-udid", "state": "Shutdown", "name": "iPad Pro", "isAvailable": true},
|
||||
{"udid": "iphone15-udid", "state": "Booted", "name": "iPhone 15", "isAvailable": true},
|
||||
{"udid": "broken-udid", "state": "Shutdown", "name": "iPhone 14", "isAvailable": false}
|
||||
],
|
||||
"com.apple.CoreSimulator.SimRuntime.iOS-16-4": [
|
||||
{"udid": "watch-udid", "state": "Shutdown", "name": "Apple Watch", "isAvailable": true}
|
||||
]
|
||||
}
|
||||
}`
|
||||
|
||||
func TestParseBootedDevice(t *testing.T) {
|
||||
cases := []struct {
|
||||
name string
|
||||
input string
|
||||
wantUDID string
|
||||
wantNil bool
|
||||
}{
|
||||
{"picks booted entry", simctlJSON, "iphone15-udid", false},
|
||||
{"none booted", `{"devices":{"r":[{"udid":"a","state":"Shutdown","name":"x","isAvailable":true}]}}`, "", true},
|
||||
{"empty list", `{"devices":{}}`, "", true},
|
||||
}
|
||||
got, err := pickSimulator("iPhone 15", available)
|
||||
for _, tc := range cases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
got, err := parseBootedDevice([]byte(tc.input))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if tc.wantNil {
|
||||
if got != nil {
|
||||
t.Fatalf("want nil, got %+v", got)
|
||||
}
|
||||
return
|
||||
}
|
||||
if got == nil || got.UDID != tc.wantUDID {
|
||||
t.Fatalf("got %+v, want UDID %q", got, tc.wantUDID)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestParseBootedDevice_InvalidJSON(t *testing.T) {
|
||||
if _, err := parseBootedDevice([]byte("not json")); err == nil {
|
||||
t.Fatal("expected error on malformed JSON")
|
||||
}
|
||||
}
|
||||
|
||||
func TestParseAvailableDevices_DropsUnavailable(t *testing.T) {
|
||||
got, err := parseAvailableDevices([]byte(simctlJSON))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got.UDID != "bbb" {
|
||||
t.Errorf("got %q, want bbb", got.UDID)
|
||||
for _, d := range got {
|
||||
if !d.IsAvailable {
|
||||
t.Fatalf("unavailable device leaked through: %+v", d)
|
||||
}
|
||||
if d.UDID == "broken-udid" {
|
||||
t.Fatalf("isAvailable=false device must not be selectable")
|
||||
}
|
||||
}
|
||||
if len(got) != 3 {
|
||||
t.Fatalf("got %d available across runtimes, want 3", len(got))
|
||||
}
|
||||
}
|
||||
|
||||
func TestPickSimulator_ByUDID(t *testing.T) {
|
||||
available := []simDevice{
|
||||
{UDID: "aaa", Name: "iPad Pro", IsAvailable: true},
|
||||
{UDID: "bbb", Name: "iPhone 14", IsAvailable: true},
|
||||
func TestPickSimulator(t *testing.T) {
|
||||
cases := []struct {
|
||||
name string
|
||||
query string
|
||||
available []simDevice
|
||||
wantUDID string // "" with wantErr means error expected
|
||||
wantErr bool
|
||||
}{
|
||||
{
|
||||
name: "by name",
|
||||
query: "iPhone 15",
|
||||
available: []simDevice{{UDID: "aaa", Name: "iPad Pro", IsAvailable: true}, {UDID: "bbb", Name: "iPhone 15", IsAvailable: true}},
|
||||
wantUDID: "bbb",
|
||||
},
|
||||
{
|
||||
name: "by udid",
|
||||
query: "aaa",
|
||||
available: []simDevice{{UDID: "aaa", Name: "iPad Pro", IsAvailable: true}, {UDID: "bbb", Name: "iPhone 14", IsAvailable: true}},
|
||||
wantUDID: "aaa",
|
||||
},
|
||||
{
|
||||
name: "unknown name errors",
|
||||
query: "Pixel 7",
|
||||
available: []simDevice{{UDID: "aaa", Name: "iPad Pro", IsAvailable: true}},
|
||||
wantErr: true,
|
||||
},
|
||||
{
|
||||
name: "empty query prefers iPhone",
|
||||
query: "",
|
||||
available: []simDevice{{UDID: "aaa", Name: "iPad mini", IsAvailable: true}, {UDID: "bbb", Name: "iPhone 16", IsAvailable: true}, {UDID: "ccc", Name: "Apple Watch", IsAvailable: true}},
|
||||
wantUDID: "bbb",
|
||||
},
|
||||
{
|
||||
name: "empty query falls back to first",
|
||||
query: "",
|
||||
available: []simDevice{{UDID: "aaa", Name: "iPad Air", IsAvailable: true}, {UDID: "bbb", Name: "Apple TV", IsAvailable: true}},
|
||||
wantUDID: "aaa",
|
||||
},
|
||||
{
|
||||
name: "empty list errors",
|
||||
query: "",
|
||||
wantErr: true,
|
||||
},
|
||||
}
|
||||
got, err := pickSimulator("aaa", available)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got.Name != "iPad Pro" {
|
||||
t.Errorf("got %q, want iPad Pro", got.Name)
|
||||
for _, tc := range cases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
got, err := pickSimulator(tc.query, tc.available)
|
||||
if tc.wantErr {
|
||||
if err == nil {
|
||||
t.Fatalf("expected error for query %q", tc.query)
|
||||
}
|
||||
return
|
||||
}
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got.UDID != tc.wantUDID {
|
||||
t.Errorf("got %q, want %q", got.UDID, tc.wantUDID)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestPickSimulator_UnknownName(t *testing.T) {
|
||||
available := []simDevice{
|
||||
{UDID: "aaa", Name: "iPad Pro", IsAvailable: true},
|
||||
}
|
||||
_, err := pickSimulator("Pixel 7", available)
|
||||
if err == nil {
|
||||
t.Fatal("expected error for unknown simulator name")
|
||||
}
|
||||
}
|
||||
|
||||
func TestPickSimulator_EmptyName_PrefersIPhone(t *testing.T) {
|
||||
available := []simDevice{
|
||||
{UDID: "aaa", Name: "iPad mini", IsAvailable: true},
|
||||
{UDID: "bbb", Name: "iPhone 16", IsAvailable: true},
|
||||
{UDID: "ccc", Name: "Apple Watch", IsAvailable: true},
|
||||
}
|
||||
got, err := pickSimulator("", available)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got.UDID != "bbb" {
|
||||
t.Errorf("got %q, want bbb (iPhone)", got.UDID)
|
||||
}
|
||||
}
|
||||
|
||||
func TestPickSimulator_EmptyName_FallsBackToFirst(t *testing.T) {
|
||||
available := []simDevice{
|
||||
{UDID: "aaa", Name: "iPad Air", IsAvailable: true},
|
||||
{UDID: "bbb", Name: "Apple TV", IsAvailable: true},
|
||||
}
|
||||
got, err := pickSimulator("", available)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got.UDID != "aaa" {
|
||||
t.Errorf("got %q, want aaa (first available)", got.UDID)
|
||||
}
|
||||
}
|
||||
|
||||
func TestPickSimulator_EmptyList(t *testing.T) {
|
||||
_, err := pickSimulator("", nil)
|
||||
if err == nil {
|
||||
t.Fatal("expected error for empty simulator list")
|
||||
}
|
||||
}
|
||||
|
||||
func TestBootedUDID_CanceledContext(t *testing.T) {
|
||||
func TestBootedUDID_CanceledContextReturnsEmpty(t *testing.T) {
|
||||
ctx, cancel := context.WithCancel(context.Background())
|
||||
cancel()
|
||||
udid := BootedUDID(ctx)
|
||||
@@ -87,3 +147,77 @@ func TestBootedUDID_CanceledContext(t *testing.T) {
|
||||
t.Errorf("expected empty UDID on canceled context, got %q", udid)
|
||||
}
|
||||
}
|
||||
|
||||
func swapSeams(t *testing.T) {
|
||||
t.Helper()
|
||||
origBoot, origWait := boot, waitForBoot
|
||||
t.Cleanup(func() { boot, waitForBoot = origBoot, origWait })
|
||||
}
|
||||
|
||||
func TestEnsureSimulator_UsesBootedSimulator(t *testing.T) {
|
||||
swapSeams(t)
|
||||
origListBooted, origListAvailable := listBooted, listAvailable
|
||||
t.Cleanup(func() { listBooted, listAvailable = origListBooted, origListAvailable })
|
||||
|
||||
listBooted = func(context.Context) (*simDevice, error) {
|
||||
return &simDevice{UDID: "iphone15-udid", Name: "iPhone 15"}, nil
|
||||
}
|
||||
availableCalled := false
|
||||
listAvailable = func(context.Context) ([]simDevice, error) {
|
||||
availableCalled = true
|
||||
return nil, nil
|
||||
}
|
||||
boot = func(context.Context, string) error {
|
||||
t.Fatal("must not boot when a simulator is already booted")
|
||||
return nil
|
||||
}
|
||||
|
||||
var out bytes.Buffer
|
||||
if err := EnsureSimulator(context.Background(), "", &out); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if availableCalled {
|
||||
t.Error("should short-circuit without listing available simulators")
|
||||
}
|
||||
if !bytes.Contains(out.Bytes(), []byte("iphone15-udid")) {
|
||||
t.Errorf("expected booted UDID in output, got %q", out.String())
|
||||
}
|
||||
}
|
||||
|
||||
func TestEnsureSimulator_BootsPickedSimulator(t *testing.T) {
|
||||
swapSeams(t)
|
||||
origListBooted, origListAvailable := listBooted, listAvailable
|
||||
t.Cleanup(func() { listBooted, listAvailable = origListBooted, origListAvailable })
|
||||
|
||||
listBooted = func(context.Context) (*simDevice, error) { return nil, nil }
|
||||
listAvailable = func(context.Context) ([]simDevice, error) {
|
||||
return []simDevice{
|
||||
{UDID: "ipad-udid", Name: "iPad Pro", IsAvailable: true},
|
||||
{UDID: "iphone15-udid", Name: "iPhone 15", IsAvailable: true},
|
||||
}, nil
|
||||
}
|
||||
var bootedUDID string
|
||||
boot = func(_ context.Context, udid string) error { bootedUDID = udid; return nil }
|
||||
waitForBoot = func(context.Context, string, time.Duration) error { return nil }
|
||||
|
||||
if err := EnsureSimulator(context.Background(), "", new(bytes.Buffer)); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if bootedUDID != "iphone15-udid" {
|
||||
t.Errorf("booted %q, want iphone15-udid (iPhone preference)", bootedUDID)
|
||||
}
|
||||
}
|
||||
|
||||
func TestEnsureSimulator_BootedListError(t *testing.T) {
|
||||
origListBooted := listBooted
|
||||
t.Cleanup(func() { listBooted = origListBooted })
|
||||
listBooted = func(context.Context) (*simDevice, error) { return nil, errors.New("xcrun blew up") }
|
||||
|
||||
err := EnsureSimulator(context.Background(), "", new(bytes.Buffer))
|
||||
if err == nil {
|
||||
t.Fatal("expected error to propagate")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "xcrun blew up") {
|
||||
t.Errorf("error should wrap cause, got %v", err)
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user