mirror of
https://github.com/priyanshujain/sanderling.git
synced 2026-10-03 19:47:10 +00:00
ci: run the 541 lines of tag-gated tests
The withsidecar tag appeared only under go build, go install and go run, so internal/sidecarassets' 167 lines, including a four-goroutine torn-write race test, had never been compiled into a test binary. The three withcompanion files were reachable only through make test-companion, which no job invoked. Both now run: the sidecar tests in check-tests while JDK 17 is still active, the companion tests in folio-ios where the bundles are already staged.
This commit is contained in:
1 parent
30febb78b8
commit
90b5e59cc1
2 files changed
+22
-1
No files matched your search
@@ -29,7 +29,7 @@ WEB_DIST := replay-ui/dist
|
||||
|
||||
GOLINES := $(shell $(GO) env GOPATH)/bin/golines
|
||||
|
||||
.PHONY: bootstrap proto sidecar sidecar-embed sanderling build sanderling-web sanderling-android sanderling-ios install test test-go test-browser test-companion test-kotlin test-folio test-spec-api test-ci-scripts spec-typecheck web-test web-typecheck web-build web-dev replay-dev docs clean release-cli release-npm-dry fmt fmt-go fmt-kotlin fmt-ts fmt-swift
|
||||
.PHONY: bootstrap proto sidecar sidecar-embed sanderling build sanderling-web sanderling-android sanderling-ios install test test-go test-browser test-companion test-sidecar test-kotlin test-folio test-spec-api test-ci-scripts spec-typecheck web-test web-typecheck web-build web-dev replay-dev docs clean release-cli release-npm-dry fmt fmt-go fmt-kotlin fmt-ts fmt-swift
|
||||
|
||||
bootstrap:
|
||||
$(GO) mod download
|
||||
@@ -148,6 +148,13 @@ test-browser:
|
||||
test-companion: $(COMPANION_EMBED) $(RUNNER_EMBED)
|
||||
$(GO) test -tags withcompanion ./internal/driver/ioscompanion/...
|
||||
|
||||
# Runs the withsidecar-tagged tests (embedded size, extraction, checksum reuse
|
||||
# and the concurrent-extraction race) against the real JAR. Kept out of `test`
|
||||
# because staging the JAR needs the android toolchain. Untagged, the package
|
||||
# builds against the stub and these never compile.
|
||||
test-sidecar: $(SIDECAR_EMBED)
|
||||
$(GO) test -tags withsidecar ./internal/sidecarassets/...
|
||||
|
||||
test-kotlin:
|
||||
ANDROID_HOME=$(ANDROID_HOME) $(GRADLE) :sidecar:test
|
||||
|
||||
|
||||
Reference in new issue
Block a user