mirror of
https://github.com/priyanshujain/sanderling.git
synced 2026-10-04 20:17:09 +00:00
refactor(ioscompanion): inline xcodegenArgs, drop tautological argv tests
This commit is contained in:
1 parent
27e2cbf956
commit
9082ad906c
3 files changed
+1
-71
No files matched your search
@@ -176,7 +176,7 @@ func (d *Driver) buildDeviceRunnerIfNeeded(ctx context.Context, companionDir, de
|
||||
return nil
|
||||
}
|
||||
|
||||
if out, genErr := runQuiet(ctx, companionDir, xcodegenArgs(filepath.Join(companionDir, "project.yml"))...); genErr != nil {
|
||||
if out, genErr := runQuiet(ctx, companionDir, "xcodegen", "--spec", filepath.Join(companionDir, "project.yml")); genErr != nil {
|
||||
return fmt.Errorf("xcodegen: %w: %s", genErr, strings.TrimSpace(string(out)))
|
||||
}
|
||||
|
||||
@@ -204,11 +204,6 @@ func buildCacheKey(companionDir string, creds signingCredentials) (string, error
|
||||
return hex.EncodeToString(sum[:]), nil
|
||||
}
|
||||
|
||||
// xcodegenArgs regenerates the runner project from its spec.
|
||||
func xcodegenArgs(specPath string) []string {
|
||||
return []string{"xcodegen", "--spec", specPath}
|
||||
}
|
||||
|
||||
// buildForTestingArgs builds the runner for a generic device destination, signed
|
||||
// through the App Store Connect API key with automatic provisioning. A generic
|
||||
// destination keeps the build off any specific booted device; the wildcard dev
|
||||
|
||||
Reference in new issue
Block a user