pj/sanderling
1
0 Fork 0
mirror of https://github.com/priyanshujain/sanderling.git synced 2026-10-04 20:17:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(build): rebuild sidecar JAR when Kotlin sources change

Browse Source 
Without source-file deps on $(SIDECAR_JAR), make never re-ran shadowJar
after a Kotlin edit, so a stale embedded JAR shipped on every install
and the new sidecar code was silently absent at runtime.
This commit is contained in:
pj committed 2026-05-31 15:56:30 +05:30
1 parent 37079a0d84
commit 726e5e0a20
1 file changed
+2 -1
Download Patch File Download Diff File Expand all files Collapse all files
Makefile
+2 -1
View File
@@ -8,6 +8,7 @@ BUF := buf
GO_PACKAGES := ./... GO_PACKAGES := ./...
SIDECAR_JAR := sidecar/build/libs/sidecar-all.jar SIDECAR_JAR := sidecar/build/libs/sidecar-all.jar
SIDECAR_EMBED := internal/sidecar/assets/sidecar-all.jar SIDECAR_EMBED := internal/sidecar/assets/sidecar-all.jar
SIDECAR_SRC := $(shell find sidecar/src -type f \( -name '*.kt' -o -name '*.kts' \) 2>/dev/null) build.gradle.kts settings.gradle.kts
SANDERLING_BIN := bin/sanderling SANDERLING_BIN := bin/sanderling
DOCS_SRC := $(shell find docs -type f -name '*.md' -not -path 'docs/_*') DOCS_SRC := $(shell find docs -type f -name '*.md' -not -path 'docs/_*')
@@ -61,7 +62,7 @@ inspect-dev: $(SIDECAR_EMBED)
web-typecheck: web-typecheck:
cd inspect-ui && bun install --frozen-lockfile && bun run typecheck cd inspect-ui && bun install --frozen-lockfile && bun run typecheck
$(SIDECAR_JAR): $(SIDECAR_JAR): $(SIDECAR_SRC)
ANDROID_HOME=$(ANDROID_HOME) $(GRADLE) :sidecar:shadowJar ANDROID_HOME=$(ANDROID_HOME) $(GRADLE) :sidecar:shadowJar
$(SIDECAR_EMBED): $(SIDECAR_JAR) $(SIDECAR_EMBED): $(SIDECAR_JAR)