test: one run-directory writer for the packages that share it

internal/tracecorpus and cmd/internal-tools/exploration-reach declared the same
24-line writeRun, identical apart from whether the seed was a parameter. The
package's charter is on it: a helper goes here once it has callers in two
packages, and stays in a package's own tests until then.
This commit is contained in:
pj committed 2026-08-22 21:23:54 +05:30
1 parent 5a0439d394
commit 5ae825109e
3 files changed
+47 -43

No files matched your search

@@ -5,6 +5,7 @@ import (
"github.com/priyanshujain/sanderling/internal/driver/ioscompanion"
"github.com/priyanshujain/sanderling/internal/hierarchy"
"github.com/priyanshujain/sanderling/internal/testsupport"
"github.com/priyanshujain/sanderling/internal/trace"
"github.com/priyanshujain/sanderling/internal/tracecorpus"
)
@@ -136,27 +137,8 @@ func measureRun(t *testing.T, seed int64, dumps ...string) Reach {
func writeRun(t *testing.T, seed int64, dumps ...string) string {
t.Helper()
directory := t.TempDir()
writer, err := trace.NewWriter(directory)
if err != nil {
t.Fatal(err)
}
if err := writer.WriteMeta(trace.Meta{Seed: seed, Platform: "web"}); err != nil {
t.Fatal(err)
}
for index, dump := range dumps {
tree, err := hierarchy.Parse(dump)
if err != nil {
t.Fatal(err)
}
if err := writer.WriteStep(trace.Step{Index: index + 1, Hierarchy: tree}); err != nil {
t.Fatal(err)
}
}
if err := writer.Close(); err != nil {
t.Fatal(err)
}
return directory
return testsupport.WriteRunFromDumps(
t, t.TempDir(), trace.Meta{Seed: seed, Platform: "web"}, dumps...)
}
func appendFinalize(t *testing.T, directory string, index int) {