From 5ad545a6ba4b4ecc92960354cc83d0c400c68e7f Mon Sep 17 00:00:00 2001
From: PJ <ipriyanshujain@gmail.com>
Date: Fri, 14 Aug 2026 22:41:53 +0530
Subject: [PATCH] ci: install idb-companion from its tap and stop interpolating
 inputs

idb-companion is not in homebrew-core, so the ios leg died before it
built anything. replay-ui expanded dispatch inputs into the shell.
---
 .github/workflows/folio.yml     |  4 +++-
 .github/workflows/replay-ui.yml | 22 ++++++++++++++++------
 2 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/folio.yml b/.github/workflows/folio.yml
index b4711ef..0578afd 100644
--- a/.github/workflows/folio.yml
+++ b/.github/workflows/folio.yml
@@ -126,8 +126,10 @@ jobs:
         with:
           bun-version: "1.3.13"
 
+      # idb-companion is not in homebrew-core, only in facebook/homebrew-fb, so
+      # it has to be named by its full tap path. xcodegen and just are core.
       - name: Install idb-companion, xcodegen and just
-        run: brew install idb-companion xcodegen just
+        run: brew install facebook/fb/idb-companion xcodegen just
 
       - name: Set up JDK 17
         uses: actions/setup-java@v4
diff --git a/.github/workflows/replay-ui.yml b/.github/workflows/replay-ui.yml
index bbd70e9..3b8cd60 100644
--- a/.github/workflows/replay-ui.yml
+++ b/.github/workflows/replay-ui.yml
@@ -4,9 +4,10 @@ name: replay-ui
 # and it is a demo of the product loop, not a merge gate.
 #
 # The shape is: produce a real trace, serve it with `sanderling replay`, then run
-# a spec against that UI. Any violation fails the job, because every property in
-# replay-ui/sanderling/spec.ts is a cross-panel agreement that holds for any
-# trace.
+# a spec against that UI. Any violation fails the job. Six of the seven
+# properties in replay-ui/sanderling/spec.ts are cross-panel agreements that hold
+# for any trace; the seventh is the stock noUncaughtExceptions. None of them
+# needs recalibrating when the fixture changes.
 
 on:
   workflow_dispatch:
@@ -89,6 +90,9 @@ jobs:
           echo "RUN_URL=http://127.0.0.1:8793/runs/$run_id/steps/1" >> "$GITHUB_ENV"
           curl -sf "http://127.0.0.1:8793/runs/$run_id/steps/1" >/dev/null
 
+      # Inputs go through env rather than into the script text: a `${{ }}` is
+      # substituted before bash ever sees the line, so a seed of `$(id)` would
+      # run as a command.
       - name: Fuzz the replay UI
         run: |
           ./bin/sanderling test \
@@ -96,10 +100,13 @@ jobs:
             --spec replay-ui/sanderling/spec.ts \
             --bundle-id "$RUN_URL" \
             --duration 10m \
-            --max-steps "${{ inputs.max-steps }}" \
-            --seed "${{ inputs.seed }}" \
+            --max-steps "$MAX_STEPS" \
+            --seed "$SEED" \
             --exit-on-violation \
             --output runs/dogfood
+        env:
+          SEED: ${{ inputs.seed }}
+          MAX_STEPS: ${{ inputs.max-steps }}
 
       - name: Summarise
         if: always()
@@ -107,13 +114,16 @@ jobs:
           {
             echo "### replay-ui dogfood"
             echo
-            echo "- seed \`${{ inputs.seed }}\`, budget ${{ inputs.max-steps }} steps"
+            echo "- seed \`$SEED\`, budget $MAX_STEPS steps"
             for dir in runs/dogfood/*/; do
               steps=$(wc -l < "$dir/trace.jsonl" | tr -d ' ')
               violations=$(grep -c '"violations":\[' "$dir/trace.jsonl" || true)
               echo "- $steps steps recorded, $violations step(s) with violations"
             done
           } >> "$GITHUB_STEP_SUMMARY"
+        env:
+          SEED: ${{ inputs.seed }}
+          MAX_STEPS: ${{ inputs.max-steps }}
 
       - name: Upload runs
         if: always()