mirror of
https://github.com/priyanshujain/sanderling.git
synced 2026-10-02 11:07:10 +00:00
fix(make): build the binary instead of matching the build directory
build/ exists at the repo root, so make build was satisfied by the directory and left a stale bin/sanderling in place.
This commit is contained in:
1 parent
d84975e042
commit
573749f17a
1 file changed
+7
-1
@@ -29,7 +29,7 @@ WEB_DIST := replay-ui/dist
|
||||
|
||||
GOLINES := $(shell $(GO) env GOPATH)/bin/golines
|
||||
|
||||
.PHONY: bootstrap proto sidecar sidecar-embed sanderling sanderling-web sanderling-android sanderling-ios install test test-go test-browser test-companion test-kotlin test-folio test-spec-api test-ci-scripts spec-typecheck web-test web-typecheck web-build web-dev replay-dev docs clean release-cli release-npm-dry fmt fmt-go fmt-kotlin fmt-ts fmt-swift
|
||||
.PHONY: bootstrap proto sidecar sidecar-embed sanderling build sanderling-web sanderling-android sanderling-ios install test test-go test-browser test-companion test-kotlin test-folio test-spec-api test-ci-scripts spec-typecheck web-test web-typecheck web-build web-dev replay-dev docs clean release-cli release-npm-dry fmt fmt-go fmt-kotlin fmt-ts fmt-swift
|
||||
|
||||
bootstrap:
|
||||
$(GO) mod download
|
||||
@@ -48,6 +48,12 @@ sidecar-embed: $(SIDECAR_EMBED)
|
||||
|
||||
sanderling: $(SANDERLING_BIN)
|
||||
|
||||
# `build` is a directory at the repository root, so `make build` matched it and
|
||||
# reported nothing to be done while leaving a stale binary in bin/ for the next
|
||||
# command to use. Aliasing it is cheaper than expecting everyone to remember
|
||||
# that the target is named after the binary.
|
||||
build: sanderling
|
||||
|
||||
$(SANDERLING_BIN): $(SIDECAR_EMBED) $(COMPANION_EMBED) $(RUNNER_EMBED) web-build
|
||||
mkdir -p bin
|
||||
$(GO) build -tags "withsidecar withcompanion" -o $(SANDERLING_BIN) ./cmd/sanderling
|
||||
|
||||
Reference in new issue
Block a user