fix(analyze): write an undefined paired p-value as null, not as NaN

A paired contrast where censoring orders no pair has no p-value, and JSON has
no NaN, so --json failed with 'marshal summary: json: unsupported value: NaN'
and wrote no summary at all after printing a complete report. The two fields
join the medians and the rates already carried as pointers, undefined reading
as null in the summary and n/a in the report.

Reachable since a clean run started being censored where it stopped: an arm
the wall clock stops before its partner ever violates orders nothing.
This commit is contained in:
pj committed 2026-08-18 20:24:10 +05:30
1 parent 8fad1937bb
commit 4bcd82a8a6
6 files changed
+60 -23

No files matched your search

@@ -1,8 +1,11 @@
package main
import (
"bytes"
"io"
"math"
"path/filepath"
"strings"
"testing"
)
@@ -116,3 +119,30 @@ func TestRun_PairedContrastFollowsWhatCensoringDetermines(t *testing.T) {
t.Errorf("a12 within pairs %.4f, want above 0.5", paired.A12)
}
}
// Nothing orders any pair here, so there is no test to report. The summary has
// to say that rather than failing to write a number that does not exist: a
// NaN p-value is not JSON and the whole summary went unwritten behind it.
func TestRun_PairedContrastWithNoOrderedPairSaysSo(t *testing.T) {
earlyDirectory, lateDirectory := wallClockArms(t, stoppedShort(20, 12), violatedAt(20, 100))
result := analyseCampaigns(t, "--paired", earlyDirectory, lateDirectory)
paired := *result.Paired
if paired.Pairs != 20 || paired.Unordered != 20 {
t.Fatalf("paired %+v, want twenty pairs and all of them unordered", paired)
}
if paired.PValue != nil || paired.HolmPValue != nil {
t.Errorf("p %v and holm p %v, want both undefined", paired.PValue, paired.HolmPValue)
}
if result.HolmFamilySize != 0 {
t.Errorf("holm family of %d, want none where nothing was tested", result.HolmFamilySize)
}
var stdout bytes.Buffer
if err := run([]string{"--paired", earlyDirectory, lateDirectory}, &stdout, io.Discard); err != nil {
t.Fatal(err)
}
if !strings.Contains(stdout.String(), "sign test over the 0 ordered pair(s), p n/a, holm p n/a") {
t.Errorf("report does not say the test was not run:\n%s", stdout.String())
}
}