mirror of
https://github.com/priyanshujain/sanderling.git
synced 2026-10-04 20:17:09 +00:00
test(folio): an unconfirmed submit belongs in the window
The count is an upper bound on the submits a window holds, so the tap that may have landed counts and committedTransactionsExceedSubmits has nothing to convict on.
This commit is contained in:
1 parent
a5066dac27
commit
46059c111b
1 file changed
+23
@@ -2,6 +2,7 @@ import assert from "node:assert/strict";
|
|||||||
import { test } from "node:test";
|
import { test } from "node:test";
|
||||||
|
|
||||||
import {
|
import {
|
||||||
|
committedTransactionsExceedSubmits,
|
||||||
countSubmitsInWindow,
|
countSubmitsInWindow,
|
||||||
isTxnSubmitTap,
|
isTxnSubmitTap,
|
||||||
readHomeTotalBalance,
|
readHomeTotalBalance,
|
||||||
@@ -149,3 +150,25 @@ test("an unreadable Home does not close the window", () => {
|
|||||||
assert.equal(trace[2]?.total, null);
|
assert.equal(trace[2]?.total, null);
|
||||||
assert.equal(trace[3]?.submits, 2);
|
assert.equal(trace[3]?.submits, 2);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// The window is an upper bound on the submits it holds, so a submit whose
|
||||||
|
// dispatch the runner could not confirm belongs in it: the tap may well have
|
||||||
|
// landed, and a bound that leaves it out is one the transaction it committed
|
||||||
|
// exceeds. That is the false conviction, a rise of one against a window of
|
||||||
|
// zero, on the property carrying most of the detection on android.
|
||||||
|
test("a submit the runner could not confirm still counts toward the window", () => {
|
||||||
|
const window = countSubmitsInWindow({
|
||||||
|
previousCount: 0,
|
||||||
|
lastAction: { kind: "Tap", on: submitOn, applied: null },
|
||||||
|
fresh: true,
|
||||||
|
});
|
||||||
|
assert.equal(window.reported, 1);
|
||||||
|
assert.equal(
|
||||||
|
committedTransactionsExceedSubmits({
|
||||||
|
countsBefore: { Travel: 3 },
|
||||||
|
countsAfter: { Travel: 4 },
|
||||||
|
submitsInWindow: window.reported,
|
||||||
|
}),
|
||||||
|
false,
|
||||||
|
);
|
||||||
|
});
|
||||||
Reference in new issue
Block a user