mirror of
https://github.com/priyanshujain/sanderling.git
synced 2026-10-02 11:07:10 +00:00
docs(verifier): unambiguousSelector no longer contradicts resolveCoordinates
The comment described the runner as preferring the selector over the element's own coordinates unconditionally. resolveCoordinates has since made the coordinates win when the selector is ambiguous, so the two files stated opposite rules for the same conflict. The reason the helper exists survives: the recorded selector is still the element's identity in the trace, and TapSelector still resolves it on the device.
This commit is contained in:
1 parent
759803e684
commit
08df960e0f
1 file changed
+8
-6
@@ -93,12 +93,14 @@ func accessibilityObject(runtime *goja.Runtime, tree *hierarchy.Tree) *goja.Obje
|
|||||||
}
|
}
|
||||||
|
|
||||||
// unambiguousSelector returns selector only when no node other than this one
|
// unambiguousSelector returns selector only when no node other than this one
|
||||||
// answers to it. The runner prefers tree.Find(action.On) over the coordinates
|
// answers to it. A shared selector names all the siblings and every consumer
|
||||||
// the element reported (resolveCoordinates) and Find takes the first match, so
|
// resolves it to the first match. The runner recovers where the action carries
|
||||||
// naming an element by a selector its siblings share sends every one of their
|
// usable coordinates, since resolveCoordinates prefers them over an ambiguous
|
||||||
// actions to the first sibling. An unnamed element keeps its own coordinates,
|
// name, but the recorded selector is also the element's identity in the trace
|
||||||
// which are already right, matching what selectorsFor does for the builtin
|
// and the replay UI, and the driver's TapSelector path resolves it on the
|
||||||
// target enumeration in pkg/spec/src/web-runtime.ts.
|
// device where nothing can tell the siblings apart. An unnamed element keeps
|
||||||
|
// its own coordinates, which are already right, matching what selectorsFor does
|
||||||
|
// for the builtin target enumeration in pkg/spec/src/web-runtime.ts.
|
||||||
func unambiguousSelector(tree *hierarchy.Tree, node *hierarchy.Node, selector string) string {
|
func unambiguousSelector(tree *hierarchy.Tree, node *hierarchy.Node, selector string) string {
|
||||||
if tree == nil || selector == "" {
|
if tree == nil || selector == "" {
|
||||||
return ""
|
return ""
|
||||||
|
|||||||
Reference in new issue
Block a user