From 04327e63b62eb4cd396f6ad890e3fd717769edd0 Mon Sep 17 00:00:00 2001
From: PJ <ipriyanshujain@gmail.com>
Date: Tue, 18 Aug 2026 00:15:55 +0530
Subject: [PATCH] test(chrome): the handle and the enumeration agree on
 editable too

The helper compared clickable alone, so the inherited-contenteditable bug
was caught by unit test only and never in a real browser.
---
 internal/driver/chrome/fact_parity_test.go    | 54 ++++++++++++-------
 .../driver/chrome/testdata/fact-parity.html   |  5 +-
 pkg/spec/test/dom-facts-probe.ts              |  7 ++-
 3 files changed, 46 insertions(+), 20 deletions(-)

diff --git a/internal/driver/chrome/fact_parity_test.go b/internal/driver/chrome/fact_parity_test.go
index bb6830f..36d126d 100644
--- a/internal/driver/chrome/fact_parity_test.go
+++ b/internal/driver/chrome/fact_parity_test.go
@@ -51,10 +51,14 @@ type elementFacts struct {
 	editable   bool
 	scrollable bool
 	hintText   string
-	// handleClickable is the clickability of the ax element a spec reaches
-	// through state.ax.find, a third place the fact is computed and the one that
-	// answered a hardcoded true while the other two resolved a selector.
+	// handleClickable and handleEditable are the same facts on the ax element a
+	// spec reaches through state.ax.find, a third place they are computed and the
+	// one that has twice been the odd one out: clickable answered a hardcoded
+	// true while the other two resolved a selector, and editable read the
+	// INHERITED isContentEditable, which makes every span inside a contenteditable
+	// container typeable.
 	handleClickable bool
+	handleEditable  bool
 	positiveBounds  bool
 }
 
@@ -170,6 +174,7 @@ func factsFromWebRuntime(
 		Scrollable      bool   `json:"scrollable"`
 		HintText        string `json:"hintText"`
 		HandleClickable bool   `json:"handleClickable"`
+		HandleEditable  bool   `json:"handleEditable"`
 		Width           int    `json:"width"`
 		Height          int    `json:"height"`
 	}
@@ -188,6 +193,7 @@ func factsFromWebRuntime(
 				scrollable:      item.Scrollable,
 				hintText:        item.HintText,
 				handleClickable: item.HandleClickable,
+				handleEditable:  item.HandleEditable,
 				positiveBounds:  hasPositiveBounds(item.Width, item.Height),
 			},
 		})
@@ -258,24 +264,36 @@ func requireBothPolarities(t *testing.T, rows []factRow) {
 
 // requireTheHandleAgreesWithTheEnumeration compares the V8 host against itself.
 // An element a spec reaches through state.ax and the same element in the
-// enumeration must be clickable to the same degree, or a spec taps a container
-// the picker calls inert. The handle resolved the fact by element.matches over
-// the tappable selector while the enumeration resolved it by membership of the
-// set that selector queried, and this is where those two answers are held
-// together over a real page: an [onclick] attribute, an onclick property that is
-// not one, elements inside a shadow root.
+// enumeration must be clickable, and typeable, to the same degree, or a spec
+// taps a container the picker calls inert and types into a box the picker calls
+// read-only. The handle resolves each fact by element.matches over a selector
+// while the enumeration resolves it by membership of the set that selector
+// queried, and this is where the two answers are held together over a real page:
+// an [onclick] attribute, an onclick property that is not one, a <span> whose
+// contenteditable is inherited from its container, elements inside a shadow root.
 func requireTheHandleAgreesWithTheEnumeration(t *testing.T, rows []factRow) {
 	t.Helper()
 	for _, row := range rows {
-		if row.facts.handleClickable != row.facts.clickable {
-			t.Errorf(
-				"%q (<%s>): the ax handle reports clickable=%v, the enumeration "+
-					"reports clickable=%v",
-				row.id,
-				row.facts.tag,
-				row.facts.handleClickable,
-				row.facts.clickable,
-			)
+		for _, fact := range []struct {
+			name        string
+			handle      bool
+			enumeration bool
+		}{
+			{"clickable", row.facts.handleClickable, row.facts.clickable},
+			{"editable", row.facts.handleEditable, row.facts.editable},
+		} {
+			if fact.handle != fact.enumeration {
+				t.Errorf(
+					"%q (<%s>): the ax handle reports %s=%v, the enumeration reports "+
+						"%s=%v",
+					row.id,
+					row.facts.tag,
+					fact.name,
+					fact.handle,
+					fact.name,
+					fact.enumeration,
+				)
+			}
 		}
 	}
 }
diff --git a/internal/driver/chrome/testdata/fact-parity.html b/internal/driver/chrome/testdata/fact-parity.html
index 75b2d1d..ac2684f 100644
--- a/internal/driver/chrome/testdata/fact-parity.html
+++ b/internal/driver/chrome/testdata/fact-parity.html
@@ -63,7 +63,10 @@
     <input id="hint-name" type="text" name="reference-field" />
     <input id="agree" type="checkbox" placeholder="not a hint" />
     <textarea id="notes"></textarea>
-    <div id="bio" contenteditable="true">bio</div>
+    <!-- contenteditable is INHERITED, so #bio-word answers isContentEditable
+         true while matching neither producer's editable selector itself. It is
+         the element the ax handle and the enumeration disagreed on. -->
+    <div id="bio" contenteditable="true">bio <span id="bio-word">word</span></div>
     <div id="menu" role="button">menu</div>
     <!-- One element per ARIA role both producers resolve as clickable. A role
          covered on one side only makes that control reachable for one host,
diff --git a/pkg/spec/test/dom-facts-probe.ts b/pkg/spec/test/dom-facts-probe.ts
index 720f846..4513fac 100644
--- a/pkg/spec/test/dom-facts-probe.ts
+++ b/pkg/spec/test/dom-facts-probe.ts
@@ -17,7 +17,11 @@ const { collectTargets, targetElements, buildAx } = __testing__;
 // reaches them and the way internal/verifier/llm.go handleLabel reads them, so
 // the comparison runs over what the model is actually shown rather than over a
 // recomputation of it.
-type AxHandle = { attrs?: Record<string, string>; clickable?: boolean };
+type AxHandle = {
+  attrs?: Record<string, string>;
+  clickable?: boolean;
+  editable?: boolean;
+};
 type Ax = { find(selector: unknown): AxHandle | undefined };
 
 function handleOf(ax: Ax, id: string): AxHandle | undefined {
@@ -45,6 +49,7 @@ function domFacts(): unknown[] {
       scrollable: target.scrollable,
       hintText: handle?.attrs?.hintText ?? "",
       handleClickable: handle?.clickable ?? false,
+      handleEditable: handle?.editable ?? false,
       width: target.width ?? 0,
       height: target.height ?? 0,
     };