mirror of
https://github.com/priyanshujain/margin-calendar.git
synced 2026-10-02 11:07:04 +00:00
Keep the hour it is now on the axis
The visible range is drawn from the events in view, and in the evening the events are behind you: the bounds end at six, everything after that is in the trailing strip, and the now line has nowhere to land. The app stops saying where in the day you are, which is most of what it is open for. Same at seven in the morning, from the other end. So when today is one of the columns, the axis takes that one hour in, and everything the widening reached over folds behind it. At half eleven at night the fixture week reads 7am to 8pm as usual, then an "8pm to 11pm" strip, then one 11pm row with the line in it. A row and a strip, not four rows of empty evening. Only the hour itself is opened, so how far the clock has drifted past the last event costs nothing. The pin sits on top of the hysteresis rather than inside it. previous.current still holds what the events and the user asked for, so an hour pinned open tonight cannot accumulate into the bounds the grid remembers tomorrow. One consequence, and it is the only place the axis is allowed to move under you: page to a week that does not contain today and the row goes again, along with the strip it was sitting under. The tick that drives it is an hour long, not a minute, because that is how often the answer changes. It lives in a new useClock alongside the minute tick the now line already had, which moves there out of GridNowLine. Both schedule off the clock rather than off an interval, so a machine that was asleep catches up on the next tick instead of drifting further out every hour. The browser suite has to say what time it is now. The shape of the axis depends on the hour a run happens at, so anything measuring a row height or counting strips pins the clock to the middle of the working day, the same way it already pins the theme and the week start. The three tests that are about the clock ask for half eleven at night, which the fixture leaves empty.
This commit is contained in:
1 parent
3323496a34
commit
67879fd6c3
8 files changed
+223
-32
No files matched your search
+13
-2
@@ -4,7 +4,17 @@
|
||||
// asking a store what it thinks happened.
|
||||
|
||||
import { expect, test } from "@playwright/test";
|
||||
import { axis, columnX, gridFit, gridReady, headerDates, hourY, openApp, settle } from "./app";
|
||||
import {
|
||||
MIDDAY,
|
||||
axis,
|
||||
columnX,
|
||||
gridFit,
|
||||
gridReady,
|
||||
headerDates,
|
||||
hourY,
|
||||
openApp,
|
||||
settle,
|
||||
} from "./app";
|
||||
|
||||
const view = (page: import("@playwright/test").Page) =>
|
||||
page.evaluate(() => document.documentElement.getAttribute("data-view"));
|
||||
@@ -72,7 +82,8 @@ test.describe("views", () => {
|
||||
test("z folds the band under the cursor, and it is still folded after a reload", async ({
|
||||
page,
|
||||
}) => {
|
||||
await openApp(page);
|
||||
// Counted strips, so the clock must not be adding one of its own.
|
||||
await openApp(page, { now: MIDDAY() });
|
||||
const fit = await gridFit(page);
|
||||
const evening = await hourY(page, "5pm");
|
||||
expect(evening).not.toBeNull();
|
||||
|
||||
Reference in new issue
Block a user